-
Notifications
You must be signed in to change notification settings - Fork 8k
stm32: tests/samples : add support for nucleo_h753zi on some tests and samples #95744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3726063
6e3ec13
926ab9b
7331a9a
915952f
cd49bfa
77a94b8
1622e50
5422257
1e60845
fb6cd3e
d1a8de7
50d0606
bf791ec
441ade7
fd8e00d
f6b1d3d
d417100
93e40a1
01f3fe6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
CONFIG_NOCACHE_MEMORY=y |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
/* | ||
* Copyright (c) 2025 STMicroelectronics | ||
* | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
&timers2 { | ||
erwango marked this conversation as resolved.
Show resolved
Hide resolved
|
||
st,prescaler = <79>; | ||
|
||
counter { | ||
etienne-lms marked this conversation as resolved.
Show resolved
Hide resolved
|
||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers3 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers4 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers5 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers6 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers7 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers12 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers13 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers14 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers15 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers16 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; | ||
|
||
&timers17 { | ||
st,prescaler = <79>; | ||
|
||
counter { | ||
status = "okay"; | ||
}; | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ | |
defined(CONFIG_BOARD_NUCLEO_G431RB) || \ | ||
defined(CONFIG_BOARD_NUCLEO_G474RE) || \ | ||
defined(CONFIG_BOARD_NUCLEO_H743ZI) || \ | ||
defined(CONFIG_BOARD_NUCLEO_H753ZI) || \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This whole thing needs to be cleaned up, the nodelabel should come from a board/SoC overlay. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes! I agree with you. For this scope, I propose to do this cleanup in a dedicated PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once again, #81458 would help on this (to avoid multiple overlays). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will propose a PR later incorporating these suggestions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
okey |
||
defined(CONFIG_BOARD_NUCLEO_L073RZ) || \ | ||
defined(CONFIG_BOARD_NUCLEO_L152RE) || \ | ||
defined(CONFIG_BOARD_DISCO_L475_IOT1) || \ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
CONFIG_DMA_TRANSFER_CHANNEL_NR_0=4 | ||
CONFIG_DMA_TRANSFER_CHANNEL_NR_1=6 | ||
CONFIG_DMA_LOOP_TRANSFER_NUMBER_OF_DMAS=2 | ||
|
||
# Required by BDMA which only has access to | ||
# a NOCACHE SRAM4 section. All other DMAs also | ||
# has access to this section. | ||
CONFIG_CODE_DATA_RELOCATION=y | ||
CONFIG_DMA_LOOP_TRANSFER_RELOCATE_SECTION="SRAM4" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Copyright (c) 2025 STMicroelectronics | ||
* | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
#include <zephyr/dt-bindings/memory-attr/memory-attr-arm.h> | ||
|
||
&dma1 { | ||
status = "okay"; | ||
}; | ||
|
||
&dma2 { | ||
status = "okay"; | ||
}; | ||
|
||
tst_dma0: &dmamux1 { | ||
status = "okay"; | ||
}; | ||
|
||
/* The BDMA driver expects the SRAM4 region | ||
* to be non-cachable. | ||
*/ | ||
&sram4 { | ||
zephyr,memory-attr = <DT_MEM_ARM(ATTR_MPU_RAM_NOCACHE)>; | ||
}; | ||
|
||
&bdma1 { | ||
status = "okay"; | ||
}; | ||
|
||
tst_dma1: &dmamux2 { | ||
status = "okay"; | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
CONFIG_DMA_LOOP_TRANSFER_CHANNEL_NR=5 | ||
CONFIG_DMA_LOOP_TRANSFER_NUMBER_OF_DMAS=2 | ||
|
||
# Required by BDMA which only has access to | ||
# a NOCACHE SRAM4 section. All other DMAs also | ||
# has access to this section. | ||
CONFIG_CODE_DATA_RELOCATION=y | ||
CONFIG_DMA_LOOP_TRANSFER_RELOCATE_SECTION="SRAM4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point? it's the same IP as stm32h735g_disco and stm32l496g_disco...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understand what you mean, but I think it is valid for
integration_platforms
, notplatform_allow
. Without specifying this board, Twister will not run this test on the NUCLEO_H753ZI.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly my point, we don't need it to, it has no added value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context of this change is to use
nucleo_h753zi
as "H7" champion on the test bench, so we need to it to be present everywhere.Cleaning up the number of boards present in these files is a good point, but we need to think about it more widely and it's likely a point for testing working group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erwango I don't think it's a great strategy to add a board like this everywhere without looking at the specifics of each sample/test.
As a starting point #94585