soc: arm: add FocalTech FT9001 SoC and evaluation board support #95959

robert-cheng-1127 · 2025-09-14T11:19:13Z

This PR adds support for the FT9001 fingerprint controller from FocalTech, which is specially designed for fingerprint sensor applications.

This PR includes initial support for the FT9001 evaluation board, with drivers as follows:

soc infrastructure
uart (register-based implementation)
clock control
reset
device tree bindings

Note: Current implementation uses direct register operations as the FocalTech HAL is not yet integrated into modules/hal.

github-actions · 2025-09-14T11:19:55Z

Hello @robert-cheng-1127, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

nordicjm

split into multiple comments before this gets reviewed e.g. one for soc, one for board

robert-cheng-1127 · 2025-09-15T06:25:47Z

split into multiple comments before this gets reviewed e.g. one for soc, one for board

Got it. I’ll split into multiple commits before review.

decsny · 2025-09-15T18:19:06Z

drivers/reset/reset_ft9001.c

is there a reason you can't use the generic reset driver?

I followed the stm32 pattern. I’ll try the generic reset driver first and see if it works for our case.
Thanks.

Hi @decsny,
I tried switching to reset-mmio, but I ran into two blockers:

Binding mismatch
The current reset-mmio.yaml doesn’t define reset-cells: [ id ] or include reset-controller.yaml.
Because of that, DTS parsing fails with:

unexpected 'reset-cells:' length in binding … 0 instead of 1

whenever a peripheral uses resets = <&rst_xxx bit>.

Init ordering
Our UART driver is PRE_KERNEL_1, but reset-mmio gets POST_KERNEL priority, causing dependency validation to fail.

The reset-mmio driver works functionally (I tested with tests/drivers/reset/mmio), but these integration issues prevent using it on our platform.

It looks like this driver is using spinlocks is why someone made it post-kernel, and I don't know why the binding is like this. These things I guess were missed in review. So fair enough, I guess we need another generic one that is not like this

robert-cheng-1127 · 2025-09-23T09:49:51Z

Rebased onto main and resolved Kconfig conflict.

nordicjm · 2025-09-23T10:13:14Z

soc/focaltech/ft9001/Kconfig.soc

+# SPDX-License-Identifier: Apache-2.0
+
+config SOC_FT9001
+  bool "FocalTech FT9001 MCU"


Kconfig uses tabs, also remove prompt from this

Sorry for the oversight. I’ll review and fix all Kconfig files in this PR.

this is not fixed e54fa19

Fixed: removed prompt and used tabs.

nordicjm · 2025-09-23T10:13:54Z

soc/focaltech/ft9001/ft9001_core.h

+/******  Cortex-M4 Processor Exceptions Numbers ****************************************************************/
+  NonMaskableInt_IRQn         = -14,    /*!< 2 Non Maskable Interrupt */


indent here is wrong

this is not fixed, I'm going to abandon this review, can you fix the issues everyone has commented, update the existing commits with the fixes, force push then ping people when the issues have been addressed and is it ready to review?
And before doing that, please read and ensure code complies with the coding standards available at:
https://docs.zephyrproject.org/latest/contribute/style/code.html
https://docs.zephyrproject.org/latest/contribute/style/cmake.html
https://docs.zephyrproject.org/latest/contribute/style/devicetree.html
https://docs.zephyrproject.org/latest/contribute/style/kconfig.html
And also the SoC/board porting guides available at:
https://docs.zephyrproject.org/latest/hardware/porting/soc_porting.html
https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html
And finally details for submitting PRs including squashing of commits (have not looked in this PR to see if things need squashing but acquainting with this guide is good): https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-requirements

Thanks!

Removed from SoC and moved to HAL module as requested.

nordicjm · 2025-09-23T10:29:14Z

drivers/serial/Kconfig.focaltech

+	bool "ft9001 MCU serial driver"
+	default y
+	depends on SERIAL
+	select SERIAL_HAS_DRIVER


where is the dt depends on?

Done.
added DT dependency.

nordicjm · 2025-09-23T10:29:23Z

drivers/serial/Kconfig.focaltech

+	  serial communication protocols.
+
+if UART_FOCALTECH
+config UART_INTERRUPT_DRIVEN


newline line 18

updated config content.

nordicjm · 2025-09-23T10:29:30Z

drivers/serial/Kconfig.focaltech

+	bool "Runtime configuration for UART controllers"
+	default y
+	help
+		Enable runtime configuration of UART controllers.


wrong ident and you are redeclaring an existing Kconfig

thanks. done

nordicjm · 2025-09-23T10:32:29Z

boards/focaltech/ft9001_eval/ft9001_eval-pinctrl.dtsi

+		};
+	};
+
+	status = "okay";


why is this here? What does this have to do with pinctrl?

nordicjm · 2025-09-23T10:32:40Z

boards/focaltech/ft9001_eval/ft9001_eval.dts

+&pinctrl {
+	status = "disabled";
+};


That was my mistake. I removed the wrong status and fixed it.

nordicjm · 2025-09-23T10:33:01Z

boards/focaltech/ft9001_eval/ft9001_eval.yaml

+# Copyright (c) 2025, FocalTech Systems CO.,Ltd
+# SPDX-License-Identifier: Apache-2.0
+
+board:


what is this file?

nordicjm · 2025-09-23T10:33:14Z

boards/focaltech/ft9001_eval/ft9001_eval_defconfig

+# Copyright (c) 2025, FocalTech Systems CO.,Ltd
+# SPDX-License-Identifier: Apache-2.0
+
+CONFIG_FLASH_LOAD_OFFSET=0x1000


why is this set here line 4?

Hi @nordicjm,
This is required by our MCU’s secure boot. The ROM checks the first 4 KB of flash for configuration, and only after that it jumps to the application. That’s why the application needs to start at 0x1000, so we set CONFIG_FLASH_LOAD_OFFSET=0x1000 in the defconfig.
Do you think this is the right place to set it, or would you recommend another location?

Put it into dts as a partition with a chosen node for code partition and set the CONFIG_USE_DT_CODE_PARTITION Kconfig

nordicjm · 2025-09-23T10:33:23Z

boards/focaltech/ft9001_eval/ft9001_eval_defconfig

+CONFIG_FLASH_LOAD_OFFSET=0x1000
+CONFIG_ARM_MPU=y
+CONFIG_HW_STACK_PROTECTION=y
+CONFIG_LOG=y


logging is not a default option

gmarull · 2025-09-23T10:36:21Z

soc/focaltech/ft9001/ft9001_core.h

@@ -0,0 +1,129 @@
+/*
+ * Copyright (c) 2025, FocalTech Systems CO.,Ltd


This file needs to be removed from in-tree; it contains much redundant stuff (like IRQ definitions, addresses, etc.)

Removed from soc

nordicjm · 2025-10-02T06:39:59Z

soc/focaltech/ft9001/Kconfig.soc

+# SPDX-License-Identifier: Apache-2.0
+
+config SOC_FT9001
+  bool "FocalTech FT9001 MCU"


this is not fixed e54fa19

nordicjm · 2025-10-02T06:42:48Z

soc/focaltech/ft9001/ft9001_core.h

+/******  Cortex-M4 Processor Exceptions Numbers ****************************************************************/
+  NonMaskableInt_IRQn         = -14,    /*!< 2 Non Maskable Interrupt */


this is not fixed, I'm going to abandon this review, can you fix the issues everyone has commented, update the existing commits with the fixes, force push then ping people when the issues have been addressed and is it ready to review?
And before doing that, please read and ensure code complies with the coding standards available at:
https://docs.zephyrproject.org/latest/contribute/style/code.html
https://docs.zephyrproject.org/latest/contribute/style/cmake.html
https://docs.zephyrproject.org/latest/contribute/style/devicetree.html
https://docs.zephyrproject.org/latest/contribute/style/kconfig.html
And also the SoC/board porting guides available at:
https://docs.zephyrproject.org/latest/hardware/porting/soc_porting.html
https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html
And finally details for submitting PRs including squashing of commits (have not looked in this PR to see if things need squashing but acquainting with this guide is good): https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-requirements

Thanks!

github-actions · 2025-10-14T16:21:18Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

robert-cheng-1127 · 2025-10-20T03:44:31Z

Hi @nordicjm, @decsny, @gmarull and @nordic-krch — thanks for the feedback so far.

I’ve addressed most comments and updated the commits; a few items are still under review.
When you have a moment, could you take another look?

Much appreciated!

Changes since last review

Formatting cleanups across Kconfig/CMake/DTS/bindings to follow Zephyr style.
Device-tree & bindings layout clarified.
Removed files that are not recommended to live in-tree.

Add devicetree bindings for the FocalTech FT9001 SoC: - Clock controller - Reset controller - UART These bindings are required by the SoC and drivers added in subsequent commits. Headers are placed under include/zephyr/dt-bindings/. Signed-off-by: Robert Cheng <[email protected]>

robert-cheng-1127 · 2025-10-21T02:51:36Z

Hi @kartben - thanks again for running the tests earlier.
I’ve addressed the issues reported by Twister, Documentation, Compliance, and Scancode.
Could you please re-run the checks when you have a moment?
Much appreciated!

Add initial support for the FocalTech FT9001 ARM Cortex-M SoC including: - SoC Kconfig and dtsi integration points - Early init and core setup - Pinctrl base definitions This prepares the tree for the FT9001 board and drivers. Signed-off-by: Robert Cheng <[email protected]>

Add support for the FocalTech FT9001 evaluation board: - Board dts/dtsi and pinmux - defconfig and board.cmake - Basic documentation The board has been tested with the following Zephyr sample: – samples/hello_world Signed-off-by: Robert Cheng <[email protected]>

Introduce the base devicetree description for the FT9001 SoC. Signed-off-by: Robert Cheng <[email protected]>

Add clock control driver for the FocalTech FT9001 SoC. Signed-off-by: Robert Cheng <[email protected]>

Add reset controller driver for the FocalTech FT9001 SoC. Signed-off-by: Robert Cheng <[email protected]>

Add the UART driver for the FocalTech FT9001 SoC. Signed-off-by: Robert Cheng <[email protected]>

sonarqubecloud · 2025-10-21T03:50:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added area: Clock Control area: Pinctrl area: UART Universal Asynchronous Receiver-Transmitter area: MAINTAINER File labels Sep 14, 2025

zephyrbot requested review from MaureenHelm, dcpleung, decsny, gmarull, nashif, nordic-krch and stephanosio September 14, 2025 11:20

zephyrbot assigned nordic-krch Sep 14, 2025

nordicjm requested changes Sep 15, 2025

View reviewed changes

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch 3 times, most recently from ebf7b84 to 33f5fdf Compare September 15, 2025 09:53

decsny reviewed Sep 15, 2025

View reviewed changes

decsny previously approved these changes Sep 18, 2025

View reviewed changes

robert-cheng-1127 requested a review from nordicjm September 19, 2025 00:42

robert-cheng-1127 dismissed decsny’s stale review via 91b9e01 September 23, 2025 09:44

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch from 33f5fdf to 91b9e01 Compare September 23, 2025 09:44

nordicjm requested changes Sep 23, 2025

View reviewed changes

nordicjm requested a review from kartben September 23, 2025 10:34

gmarull requested changes Sep 23, 2025

View reviewed changes

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch from b7e4e84 to b032dc8 Compare September 24, 2025 10:45

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch from b032dc8 to fdfe2f8 Compare October 1, 2025 12:28

zephyrbot added the area: Boards/SoCs label Oct 1, 2025

nordicjm requested a review from decsny October 2, 2025 06:38

nordicjm requested changes Oct 2, 2025

View reviewed changes

decsny removed their request for review October 2, 2025 12:49

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch from fdfe2f8 to 44c5aa9 Compare October 14, 2025 16:20

github-actions bot added manifest manifest-hal_focaltech DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 14, 2025

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch 2 times, most recently from 7294461 to cf5d947 Compare October 15, 2025 07:48

github-actions bot removed manifest manifest-hal_focaltech DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 15, 2025

robert-cheng-1127 requested a review from nordicjm October 15, 2025 09:53

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch from a3576b7 to fefd013 Compare October 17, 2025 02:35

robert-cheng-1127 requested a review from decsny October 17, 2025 02:50

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch from fefd013 to 47fb90f Compare October 20, 2025 03:31

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch from 47fb90f to dadd691 Compare October 21, 2025 01:53

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch from dadd691 to fb49b8c Compare October 21, 2025 02:38

robert-cheng-1127 added 6 commits October 21, 2025 11:21

dts: arm: focaltech: add ft9001 SoC dtsi

5418cbf

Introduce the base devicetree description for the FT9001 SoC. Signed-off-by: Robert Cheng <[email protected]>

drivers: clock_control: focaltech: add ft9001 clock control driver

d147a72

Add clock control driver for the FocalTech FT9001 SoC. Signed-off-by: Robert Cheng <[email protected]>

drivers: reset: focaltech: add ft9001 reset controller driver

cafea6e

Add reset controller driver for the FocalTech FT9001 SoC. Signed-off-by: Robert Cheng <[email protected]>

drivers: serial: focaltech: add ft9001 serial driver

03fd8d3

Add the UART driver for the FocalTech FT9001 SoC. Signed-off-by: Robert Cheng <[email protected]>

robert-cheng-1127 force-pushed the soc-focaltech-ft9001-support branch from fb49b8c to 03fd8d3 Compare October 21, 2025 03:23

		/**** Cortex-M4 Processor Exceptions Numbers **************************************************************/
		NonMaskableInt_IRQn = -14, /!< 2 Non Maskable Interrupt /

		@@ -0,0 +1,129 @@
		/*
		* Copyright (c) 2025, FocalTech Systems CO.,Ltd

soc: arm: add FocalTech FT9001 SoC and evaluation board support #95959

Are you sure you want to change the base?

soc: arm: add FocalTech FT9001 SoC and evaluation board support #95959

Conversation

robert-cheng-1127 commented Sep 14, 2025

Uh oh!

github-actions bot commented Sep 14, 2025

Uh oh!

nordicjm left a comment

Choose a reason for hiding this comment

Uh oh!

robert-cheng-1127 commented Sep 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robert-cheng-1127 Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robert-cheng-1127 commented Sep 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robert-cheng-1127 Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nordicjm Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robert-cheng-1127 Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nordicjm Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robert-cheng-1127 Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

robert-cheng-1127 Sep 18, 2025 •

edited

Loading

robert-cheng-1127 Oct 14, 2025 •

edited

Loading

nordicjm Oct 2, 2025 •

edited

Loading

robert-cheng-1127 Oct 14, 2025 •

edited

Loading

nordicjm Sep 29, 2025 •

edited

Loading

robert-cheng-1127 Oct 14, 2025 •

edited

Loading

nordicjm Oct 2, 2025 •

edited

Loading

github-actions bot commented Oct 14, 2025 •

edited

Loading