modules: mbedtls: add helper Kconfig PSA_CRYPTO #96415
Open
+68
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriosetti
force-pushed
the
psa-crypto-provider
branch
8 times, most recently
from
f28c600 to
e84cc0d
Compare
zephyrbot
requested review from
HaavardRei,
HoZHel,
PavelVPV,
Thalley,
alwa-nordic,
carlescufi,
cvinayak,
erbr-ot,
hermabe,
jhedberg,
ppryga,
rugeGerritsen,
sjanc,
thoh-ot and
wopu-ot
valeriosetti
dismissed stale reviews from krish2718, jhedberg, and tomi-font
via
a1d0c73
valeriosetti
force-pushed
the
psa-crypto-provider
branch
from
b85f601 to
a1d0c73
Compare
zephyrbot
requested review from
StefanHri,
alwa-nordic,
jhedberg and
krish2718
|
Hold on with reviews: apparently I did a rebase mistake and I brought back |
The dependency should be PSA_CRYPTO_CLIENT and not MBEDTLS_PSA_CRYPTO_CLIENT because the former is more generic. TF-M can indeed provide PSA Crypto API, not only Mbed TLS. Signed-off-by: Valerio Setti <[email protected]>
The driver code only relies on legacy Mbed TLS crypto, not on PSA API, so enabling MBEDTLS_PSA_CRYPTO_C is not needed here. Signed-off-by: Valerio Setti <[email protected]>
…_EFR32 The driver only uses psa_generate_random() so ENTROPY_C is not required. Signed-off-by: Valerio Setti <[email protected]>
The goal of new Kconfig PSA_CRYPTO_PROVIDER is to automatically enable any of the PSA Crypto API provider available for the platform without having the user to manually pick the proper one. This provider can be either TF-M, if that's enabled in the build, or Mbed TLS otherwise. PSA_CRYPTO_PROVIDER simplifies also modules/subsystem Kconfigs removing blocks as: select MBEDTLS if !BUILD_WITH_TFM select MBEDTLS_PSA_CRYPTO_C if !BUILD_WITH_TFM Kconfig PSA_CRYPTO_PROVIDER_CUSTOM is also added to allow the end user to add a custom implementation of PSA Crypto API instead of TF-M or Mbed TLS ones. Signed-off-by: Valerio Setti <[email protected]>
Remove previous Kconfig choices CONFIG_BT_MESH_USES_MBEDTLS_PSA and CONFIG_BT_MESH_USES_TFM_PSA and use CONFIG_PSA_CRYPTO instead. This commit also updates test code accordingly. Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
psa-crypto-provider
branch
from
a1d0c73 to
7dd0de0
Compare
tomi-font
reviewed
Oct 10, 2025
Update release-notes about the following additions: - CONFIG_PSA_CRYPTO - CONFIG_PSA_CRYPTO_PROVIDER_TFM - CONFIG_PSA_CRYPTO_PROVIDER_MBEDTLS - CONFIG_PSA_CRYPTO_PROVIDER_CUSTOM Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
psa-crypto-provider
branch
from
7dd0de0 to
925b69a
Compare
|
tomi-font
approved these changes
Oct 10, 2025
alxelax
approved these changes
Oct 10, 2025
| bool "PSA Crypto API" | ||
| help | ||
| Enable a PSA Crypto API provider in the build. If TF-M is enabled then | ||
| it will be used for this scope, otherwise Mbed TLS will be used. |
There was a problem hiding this comment.
The help text is saying that there are only 2 options.
It should also mention the custom/out-of-tree option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that in the Zephyr codebase there are several occurrences of the following pattern:
This is used to enable Mbed TLS' PSA Crypto Core when TF-M is not available in the build. This is not really nice because it brings the PSA Crypto enablement logic down to the subsystem/module/sample/test using it and it also causes code duplication.
The goal of this PR is to introduce
PSA_CRYPTO_PROVIDERas a solution to this problem. This is meant to simplify the end user life: they will just need to enablePSA_CRYPTO_PROVIDERand then Zephyr will take care of enabling what's needed based on the current platform.