sam_e54_xpro : Add support for PWM using tcc peripheral #96963
Conversation
zephyrbot
added
area: Devicetree Bindings
area: PWM
zephyrbot
requested review from
albertofloyd,
anangl,
henrikbrixandersen,
jvasanth1,
nandojve,
pdgendt,
stephanosio and
VenkatKotakonda
mchp-asif
force-pushed
the
g1_pwm_tcc_driver_upstream
branch
from
20edb6b to
8ba6293
Compare
drivers/pwm/pwm_mchp_tcc_g1.c
Outdated
| uint32_t top = ((uint32_t)(1 << mchp_pwm_cfg->max_bit_width) - 1); | ||
|
|
||
| MCHP_PWM_DATA_LOCK(&mchp_pwm_data->lock); | ||
| do { |
There was a problem hiding this comment.
its possible to avoid multiple returns without using do-while with if-else.
There was a problem hiding this comment.
refactored the code to use if-else for avoiding multiple returns
| reg = <0x42000c00 0x2000>; | ||
| interrupts = <97 0>, <98 0>, <99 0>, <100 0>; | ||
| clocks = <&mclkperiph CLOCK_MCHP_MCLKPERIPH_ID_APBC_TCC2>, | ||
| <&gclkperiph CLOCK_MCHP_GCLKPERIPH_ID_TCC2>; |
There was a problem hiding this comment.
Should be aligned vertically
There was a problem hiding this comment.
Updated the alignment.
Adds the dts nodes and binding yamls for pwm driver using tcc peripheral. Signed-off-by: Muhammed Asif <[email protected]>
Add pwm driver using tcc g1 peripheral. Adds the support for generating pwm output. Supports both 16-bit and 24bit mode of tcc peripheral Signed-off-by: Muhammed Asif <[email protected]>
Added the pinmuxing as well as the dts node for supporting blinky on sam_e54_xpro board. Signed-off-by: Muhammed Asif <[email protected]>
mchp-asif
force-pushed
the
g1_pwm_tcc_driver_upstream
branch
from
8ba6293 to
16fde87
Compare
|
| @@ -0,0 +1,71 @@ | |||
| # Copyright (c) 2025 Microchip Technology Inc. | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
There was a problem hiding this comment.
Please add a title property providing a brief, descriptive name for the peripheral.
| @@ -0,0 +1,30 @@ | |||
| # Copyright (c) 2025 Microchip Technology Inc. | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
There was a problem hiding this comment.
Please add a title property providing a brief, descriptive name for the peripheral.
| */ | ||
| static inline void tcc_sync_wait(void *pwm_reg) | ||
| { | ||
| while ((PWM_REG(pwm_reg)->TCC_SYNCBUSY) != 0) { |
There was a problem hiding this comment.
Use WAIT_FOR macro with required timeout.
Adds dts nodes of the available tcc nodes in all the series
Added the driver which can generate pwm using tcc peripheral in output on respective pins. It can work either in16 or 24 bit mode.
Added the blinky_pwm support for led on board.