modem: backends: isr: notify remaining RX bytes #97132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the modem backend UART ISR driver would fail to notify when additional RX bytes remained in the buffer after a receive operation. The fix ensures that a MODEM_PIPE_EVENT_RECEIVE_READY event is triggered when there are still unread bytes available.
- Adds notifications when RX buffer still contains data after reading
- Improves code formatting by splitting a long function call across multiple lines
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
If there are still bytes in the RX buffer, trigger another MODEM_PIPE_EVENT_RECEIVE_READY event. Signed-off-by: Ryan Erickson <[email protected]>
rerickson1
force-pushed
the
PR/up_modem_backend_isr
branch
from
f5ed9f9 to
1f91de7
Compare
rerickson1
changed the title
|
SeppoTakalo
approved these changes
Oct 8, 2025
JordanYates
approved these changes
Oct 8, 2025
rerickson1
added
bug
bjarki-andreasen
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are still bytes in the RX buffer, trigger another MODEM_PIPE_EVENT_RECEIVE_READY event.
The async backends do this, this brings the ISR backend inline to behave like the others.
fixes: #97131