Adding dave2d driver support on lvgl for Renesas RA devices #97163

duynguyenxa · 2025-10-08T06:27:52Z

This PR introduces support for D/AVE 2D (Dave2D) hardware acceleration in LVGL on Zephyr OS.
The integration allows LVGL’s rendering engine to utilize the Renesas D/AVE 2D GPU for improved graphics performance, enabling faster UI updates and smoother animations on supported hardware platforms (e.g., RA8D1, RA8P1).

github-actions · 2025-10-08T06:31:32Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_renesas	zephyrproject-rtos/hal_renesas@`bc51c0b`	zephyrproject-rtos/hal_renesas#154	zephyrproject-rtos/hal_renesas#154/files
lvgl	zephyrproject-rtos/lvgl@`b03edc8` (`zephyr_2025_06_11`)	zephyrproject-rtos/lvgl#67	zephyrproject-rtos/lvgl#67/files

Additional metadata changed:

Name	URL	Submodules	West cmds	`module.yml`	Blobs
hal_renesas				✏	1x 🆕

⛔ DNM label due to: 2 projects with PR revision, 1 project with metadata changes and 1 blob change

Note: This message is automatically posted and updated by the Manifest GitHub Action.

uLipe · 2025-10-08T12:41:07Z

Thank you for bringing this one @duynguyenxa, I was about to ask you about the progress on this.

JarmouniA

The only Dave2D I know is https://m.youtube.com/channel/UCVYamHliCI9rw1tHR1xbkfw :)

Copilot

Pull Request Overview

This PR introduces D/AVE 2D hardware acceleration support for LVGL on Renesas RA devices (RA8D1, RA8P1), enabling GPU-accelerated graphics rendering for improved UI performance. The integration includes driver implementation, device tree bindings, board configurations, and demo updates.

Key Changes

Adds Renesas DRW (D/AVE 2D) driver with interrupt handling and memory management
Updates module revisions to pull in LVGL dave2d support and Renesas HAL changes
Configures board support and display timing optimizations for RA8D1/RA8P1 platforms

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
west.yml	Updates module revisions for hal_renesas and lvgl to pull in dave2d support
drivers/misc/renesas_drw/	New DRW driver implementation with interrupt handling and memory allocation
dts/bindings/misc/renesas,ra-drw.yaml	Device tree binding for DRW hardware
dts/arm/renesas/ra/ra8/	Device tree node definitions for DRW on RA8D1/RA8P1 SoCs
boards/renesas/	Board-specific DRW enablement and interrupt configuration
modules/lvgl/Kconfig	LVGL configuration for dave2d draw engine support
samples/modules/lvgl/demos/	Demo configuration updates for widgets and performance monitoring

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

drivers/misc/renesas_drw/Kconfig.renesas_ra_drw

drivers/misc/renesas_drw/Kconfig

drivers/misc/renesas_drw/renesas_ra_drw.c

modules/lvgl/Kconfig

faxe1008 · 2025-10-14T11:04:19Z

The overall driver looks good now, although I am missing the hardware to test it. Also the pending issue around the LVGL fork sync needs to be addressed first I guess.

thenguyenyf · 2025-10-14T16:59:45Z

drivers/misc/renesas_drw/Kconfig.renesas_ra_drw

+config RENESAS_RA_DRW
+	bool "Renesas RA DRW Driver"
+	depends on DT_HAS_RENESAS_RA_DRW_ENABLED
+	select USE_RA_FSP_DRW if SOC_FAMILY_RENESAS_RA


Is this check redundant? It is already passed by DT_HAS_RENESAS_RA_DRW_ENABLED.

Suggested change

select USE_RA_FSP_DRW if SOC_FAMILY_RENESAS_RA

select USE_RA_FSP_DRW

thenguyenyf · 2025-10-14T17:04:57Z

drivers/misc/renesas_drw/renesas_ra_drw.c

+	uint32_t int_status;
+	IRQn_Type irq = R_FSP_CurrentIrqGet();
+	/* Read D/AVE 2D interrupt status */
+	int_status = R_DRW->STATUS;
+	/* Get current IRQ number */


Probably better for readability

Suggested change

uint32_t int_status;

IRQn_Type irq = R_FSP_CurrentIrqGet();

/* Read D/AVE 2D interrupt status */

int_status = R_DRW->STATUS;

/* Get current IRQ number */

uint32_t int_status = R_DRW->STATUS; /* Read D/AVE 2D interrupt status */

IRQn_Type irq = R_FSP_CurrentIrqGet(); /* Get current IRQ number */

thenguyenyf · 2025-10-14T17:15:22Z

drivers/misc/renesas_drw/renesas_ra_drw.c

+#define DRW_INIT(inst)                                                                             \
+	static int drw_renesas_ra_configure_func_##inst(void)                                      \
+	{                                                                                          \
+		R_ICU->IELSR[DT_INST_IRQ_BY_NAME(inst, drw, irq)] = ELC_EVENT_DRW_INT;             \
+		IRQ_CONNECT(DT_INST_IRQ_BY_NAME(inst, drw, irq),                                   \
+			    DT_INST_IRQ_BY_NAME(inst, drw, priority), drw_zephyr_irq_handler,      \
+			    DEVICE_DT_INST_GET(inst), 0);                                          \
+		irq_enable(DT_INST_IRQ_BY_NAME(inst, drw, irq));                                   \
+		return 0;                                                                          \
+	}                                                                                          \
+	static int renesas_drw_init_##inst(const struct device *dev)                               \
+	{                                                                                          \
+		ARG_UNUSED(dev);                                                                   \
+		return drw_renesas_ra_configure_func_##inst();                                     \
+	}                                                                                          \
+	DEVICE_DT_INST_DEFINE(inst, renesas_drw_init_##inst, NULL, NULL, NULL, POST_KERNEL,        \
+			      CONFIG_RENESAS_DRW_INIT_PRIORITY, NULL);
+
+DT_INST_FOREACH_STATUS_OKAY(DRW_INIT)


Better to use the SYS_INIT, due to this is a singleton instance driver

thenguyenyf · 2025-10-14T17:22:50Z

drivers/misc/renesas_drw/renesas_ra_drw.c

+		d1_device_flex *p_context = (d1_device_flex *)R_FSP_IsrContextGet(irq);
+
+		if (p_context->dlist_indirect_enable &&
+		    (NULL != (uint32_t *)*(p_context->pp_dlist_indirect_start))) {
+			R_DRW->DLISTSTART = *(p_context->pp_dlist_indirect_start);
+			p_context->pp_dlist_indirect_start++;
+		} else {
+			k_sem_give(&d1_queryirq_sem);
+		}
+	}


I think it's better for readability

Suggested change

d1_device_flex *p_context = (d1_device_flex *)R_FSP_IsrContextGet(irq);

if (p_context->dlist_indirect_enable &&

(NULL != (uint32_t *)*(p_context->pp_dlist_indirect_start))) {

R_DRW->DLISTSTART = *(p_context->pp_dlist_indirect_start);

p_context->pp_dlist_indirect_start++;

} else {

k_sem_give(&d1_queryirq_sem);

}

}

d1_device_flex *p_d1_handle = (d1_device_flex *)R_FSP_IsrContextGet(irq);

if (p_d1_handle != NULL) {

uint32_t **pp_dlist_indirect_start = (uint32_t **)p_d1_handle->pp_dlist_indirect_start;

if (p_d1_handle->dlist_indirect_enable && *pp_dlist_indirect_start != NULL) {

R_DRW->DLISTSTART = *pp_dlist_indirect_start;

p_d1_handle->pp_dlist_indirect_start++;

} else {

k_sem_give(&d1_queryirq_sem);

}

}

}

thenguyenyf · 2025-10-14T17:36:16Z

drivers/misc/renesas_drw/renesas_ra_drw.c

+		R_DRW->IRQCTL = DRW_PRV_IRQCTL_ALLIRQ_CLEAR_AND_DLISTIRQ_ENABLE;
+		R_FSP_IsrContextSet((IRQn_Type)VECTOR_NUMBER_DRW_INT, handle);


Base on the d1_shutdownirq_intern, I think we should move the irq_enable(VECTOR_NUMBER_DRW_INT); from init function to here.
Beside that, maybe you'd like to swap the call order?

Suggested change

R_DRW->IRQCTL = DRW_PRV_IRQCTL_ALLIRQ_CLEAR_AND_DLISTIRQ_ENABLE;

R_FSP_IsrContextSet((IRQn_Type)VECTOR_NUMBER_DRW_INT, handle);

R_FSP_IsrContextSet((IRQn_Type)VECTOR_NUMBER_DRW_INT, handle);

irq_enable(VECTOR_NUMBER_DRW_INT);

R_DRW->IRQCTL = DRW_PRV_IRQCTL_ALLIRQ_CLEAR_AND_DLISTIRQ_ENABLE;

uLipe

Great work! It will simplify a lot the Weather Demo from Renesas under Zephyr.

uLipe · 2025-10-14T21:16:25Z

drivers/misc/renesas_drw/renesas_ra_drw.c

+	DEVICE_DT_INST_DEFINE(inst, renesas_drw_init_##inst, NULL, NULL, NULL, POST_KERNEL,        \
+			      CONFIG_RENESAS_DRW_INIT_PRIORITY, NULL);
+
+DT_INST_FOREACH_STATUS_OKAY(DRW_INIT)


The DT_INST and its foreach version is also responsible to manage the allocation of the driver instance and runtime data, there are examples on how to instantiate singleton devices ( check the video input subsystems) but I'd rather to leave this as is because the runtime result will be the same of using a cusom singleton initialization flow.

This commit update commit ID for Renesas hal and lvgl module to support dave2d library Signed-off-by: Duy Nguyen <[email protected]>

First commit to add support for Renesas RA drw driver Signed-off-by: Duy Nguyen <[email protected]>

Add DRW nodes to r7fa8d1xh.dtsi and r7ka8p1kflcac.dtsi Signed-off-by: Duy Nguyen <[email protected]>

Add support for drw driver on ek_ra8p1 and ek_ra8d1 Signed-off-by: Duy Nguyen <[email protected]>

Adjust GLCDC panel timing parameters for rtklcdpar1s00001be display shield Signed-off-by: Duy Nguyen <[email protected]>

Add extra configs in sample.yaml to LVGL demos for Renesas EK-RA8P1 and EK-RA8D1 boards. Add new overlay file for EK-RA8P1 to adjust flash partitions. Signed-off-by: Duy Nguyen <[email protected]>

sonarqubecloud · 2025-10-15T06:08:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added area: Devicetree Bindings area: Shields Shields (add-on boards) area: Samples Samples area: Boards/SoCs area: LVGL Light and Versatile Graphics Library Support platform: Renesas RA Renesas Electronics Corporation, RA labels Oct 8, 2025

zephyrbot requested review from JarmouniA, KhiemNguyenT, avisconti, erwango, faxe1008, jfischer-no, kartben, khoa-nguyen-18, nashif, pdgendt, soburi, thaoluonguw, thenguyenyf and uLipe October 8, 2025 06:29

zephyrbot assigned kartben Oct 8, 2025

duynguyenxa force-pushed the renesas_drw_driver_support branch from afdac7c to fcd57a6 Compare October 8, 2025 06:30

github-actions bot added manifest manifest-lvgl manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Added labels Oct 8, 2025

duynguyenxa force-pushed the renesas_drw_driver_support branch 2 times, most recently from c5f52c9 to 198bda1 Compare October 8, 2025 06:50

duynguyenxa force-pushed the renesas_drw_driver_support branch from 2212a8d to 7c3cf66 Compare October 8, 2025 12:42

JarmouniA reviewed Oct 8, 2025

View reviewed changes

kartben requested a review from Copilot October 8, 2025 19:56

Copilot AI reviewed Oct 8, 2025

View reviewed changes

drivers/misc/renesas_drw/Kconfig.renesas_ra_drw Outdated Show resolved Hide resolved

drivers/misc/renesas_drw/Kconfig Outdated Show resolved Hide resolved

faxe1008 reviewed Oct 9, 2025

View reviewed changes

duynguyenxa force-pushed the renesas_drw_driver_support branch from 7c3cf66 to a85b72c Compare October 14, 2025 07:24

zephyrbot requested review from VynDragon, asmellby, faxe1008, jhedberg, sreeramIfx and sylvioalves October 14, 2025 07:26

thenguyenyf reviewed Oct 14, 2025

View reviewed changes

uLipe previously approved these changes Oct 14, 2025

View reviewed changes

thenguyenyf added this to the v4.3.0 milestone Oct 15, 2025

duynguyenxa added 6 commits October 15, 2025 03:28

manifest: Update revision for renesas hal and lvgl

2e7fdd1

This commit update commit ID for Renesas hal and lvgl module to support dave2d library Signed-off-by: Duy Nguyen <[email protected]>

drivers: misc: Initial support for drw driver on Renesas RA

f84b1f6

First commit to add support for Renesas RA drw driver Signed-off-by: Duy Nguyen <[email protected]>

dts: arm: renesas: Add DRW nodes for RA8D1 and RA8P1 SoCs

c594331

Add DRW nodes to r7fa8d1xh.dtsi and r7ka8p1kflcac.dtsi Signed-off-by: Duy Nguyen <[email protected]>

boards: renesas: Add support for drw driver on RA8

6dc091f

Add support for drw driver on ek_ra8p1 and ek_ra8d1 Signed-off-by: Duy Nguyen <[email protected]>

boards: shields: adjust GLCDC panel timing parameters

b03706b

Adjust GLCDC panel timing parameters for rtklcdpar1s00001be display shield Signed-off-by: Duy Nguyen <[email protected]>

samples: modules: lvgl: update for ek_ra8p1 and ek_ra8d1

a37e85d

Add extra configs in sample.yaml to LVGL demos for Renesas EK-RA8P1 and EK-RA8D1 boards. Add new overlay file for EK-RA8P1 to adjust flash partitions. Signed-off-by: Duy Nguyen <[email protected]>

duynguyenxa dismissed uLipe’s stale review via a37e85d October 15, 2025 05:43

duynguyenxa force-pushed the renesas_drw_driver_support branch from a85b72c to a37e85d Compare October 15, 2025 05:43

zephyrbot requested review from d3zd3z, krish2718 and sachinthegreen October 15, 2025 05:45

josuah mentioned this pull request Oct 15, 2025

boards: qualcomm: Add QCC744M EVK #97649

Open

	select USE_RA_FSP_DRW if SOC_FAMILY_RENESAS_RA
	select USE_RA_FSP_DRW

		R_DRW->IRQCTL = DRW_PRV_IRQCTL_ALLIRQ_CLEAR_AND_DLISTIRQ_ENABLE;
		R_FSP_IsrContextSet((IRQn_Type)VECTOR_NUMBER_DRW_INT, handle);

Adding dave2d driver support on lvgl for Renesas RA devices #97163

Are you sure you want to change the base?

Adding dave2d driver support on lvgl for Renesas RA devices #97163

Conversation

duynguyenxa commented Oct 8, 2025

Uh oh!

github-actions bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uLipe commented Oct 8, 2025

Uh oh!

JarmouniA left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

faxe1008 commented Oct 14, 2025

Uh oh!

thenguyenyf Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

thenguyenyf Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

thenguyenyf Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

thenguyenyf Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

thenguyenyf Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

uLipe left a comment

Choose a reason for hiding this comment

Uh oh!

uLipe Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 15, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Oct 8, 2025 •

edited

Loading