scripts: Refactor build/runner west logging to not use deprecated APIs

[decsny]

Refactor build/runner scripts to not use the deprecated west logging API to stop the dozens of python warnings that happen when running west build and west flash or west whatever.

Fixes #92475

This all has to be one commit because of all the coupling of dependencies across these scripts, it would not be bisectable any other way.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[marc-hb]

@mbolivar is it really required to add some west_command everywhere now? In every function signature, even the most basic and "static" ones? Adding a self argument is not too bad, but _ensure_min_version(west_command,... ) looks a bit ugly IMHO. Logging is one the most basic feature, it should have very little dependencies :-(

What are the best practice(s)? If any, please add them to zephyrproject-rtos/west#149, thanks!

[pdgendt]

Thanks @decsny for doing this! This is a welcome patch in preparation for West v2 where the deprecated log module would be dropped.

@marc-hb we shouldn't rely on a global log state/module IMO, so not sure if there's a better alternative?

[mbolivar]

Logging is one the most basic feature, it should have very little dependencies :-(

What are the best practice(s)? If any, please add them to zephyrproject-rtos/west#149, thanks!

@marc-hb is anything missing from here in terms of best practices and rationale?

https://github.com/zephyrproject-rtos/west/blob/594a789d19f2c66c1937210e67bf9e59c2a4387c/src/west/log.py#L6

[marc-hb]

@marc-hb is anything missing from here in terms of best practices and rationale?

Yes; a nicer way? :-)

[mbolivar]

Not sure what you're asking for, but the successor to the global state in the west.log module is the per-instance state in https://github.com/zephyrproject-rtos/west/blob/594a789d19f2c66c1937210e67bf9e59c2a4387c/src/west/commands.py#L410.

Your objection seems to be about the verbosity of passing a WestCommand instance around instead of implicitly relying on the global state. I guess one potentially 'nicer' way to handle that here would be to reorganize this code to stash the WestCommand in an instance variable inside of a new class instead of using module-level functions. I don't have any other suggestions right now.