Skip to content

subsys: usb: device_next: class: fix format specifier warning in debug log #97251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −1
Closed

subsys: usb: device_next: class: fix format specifier warning in debug log #97251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion subsys/usb/device_next/class/usbd_midi2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ int usbd_midi_send(const struct device *dev, const struct midi_ump ump)
size_t buflen = 4 * words;
uint32_t word;

LOG_DBG("Send MT=%X group=%X", UMP_MT(ump), UMP_GROUP(ump));
LOG_DBG("Send MT=%X group=%lX", UMP_MT(ump), UMP_GROUP(ump));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type is UMP_GROUP? Wouldn't PRIx32 be better here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the log message, UMP_GROUP is a long unsigned int.

I also tested with PRIx32 using this instruction:

LOG_DBG("Send MT=0x%" PRIx32 " group=0x%" PRIx32, (uint32_t)UMP_MT(ump), (uint32_t)UMP_GROUP(ump));

It builds successfully, but I am not sure if this format is appropriate for printing it.

if (data->altsetting != MIDI2_ALTERNATE) {
LOG_WRN("MIDI2.0 is not enabled");
return -EIO;
Expand Down