subsys: usb: device_next: class: fix format specifier warning in debug log #97251
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: USB
djiatsaf-st
force-pushed
the
fix_build_usb_midi
branch
from
2018ec5 to
454cf09
Compare
Corrected the format specifier in LOG_DBG to match the actual type of UMP_GROUP(ump), which returns an unsigned long. Changed '%X' to '%lX' to avoid -Wformat warnings. Signed-off-by: Fabrice DJIATSA <[email protected]>
djiatsaf-st
force-pushed
the
fix_build_usb_midi
branch
from
454cf09 to
bd457db
Compare
|
tmon-nordic
reviewed
Oct 9, 2025
| uint32_t word; | ||
|
|
||
| LOG_DBG("Send MT=%X group=%X", UMP_MT(ump), UMP_GROUP(ump)); | ||
| LOG_DBG("Send MT=%X group=%lX", UMP_MT(ump), UMP_GROUP(ump)); |
There was a problem hiding this comment.
What type is UMP_GROUP? Wouldn't PRIx32 be better here?
There was a problem hiding this comment.
According to the log message, UMP_GROUP is a long unsigned int.
I also tested with PRIx32 using this instruction:
LOG_DBG("Send MT=0x%" PRIx32 " group=0x%" PRIx32, (uint32_t)UMP_MT(ump), (uint32_t)UMP_GROUP(ump));
It builds successfully, but I am not sure if this format is appropriate for printing it.
tmon-nordic
requested changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the format specifier in LOG_DBG to match the actual type of UMP_GROUP(ump), which returns an unsigned long. Changed '%X' to '%lX' to avoid -Wformat warnings.
To reproduce :
west build -p -b nucleo_g0b1re/stm32g0b1xx samples/subsys/usb/midi -T sample.usb_device_next.midiLog message :