drivers: ethernet: stm32: HAL return value handling #97281
+42
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
ClaCodes,
decsny,
djiatsaf-st,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
lmajewski,
maass-hamburg,
marwaiehm-st,
mathieuchopstm and
pdgendt
drivers/ethernet/eth_stm32_hal_v2.c
Outdated
| { | ||
| __ASSERT_NO_MSG(heth != NULL); | ||
| ETH_MACFilterConfigTypeDef MACFilterConf; | ||
| HAL_StatusTypeDef hal_ret; |
There was a problem hiding this comment.
Might need __maybe_unused because value is never consumed w/o asserts enabled (let's see what CI has to say)
drivers/ethernet/eth_stm32_hal_v2.c
Outdated
| HAL_ETH_GetMACConfig(heth, &mac_config); | ||
| if (HAL_ETH_GetMACConfig(heth, &mac_config) != HAL_OK) { | ||
| LOG_ERR("HAL_ETH_GetMACConfig: failed: %d", hal_ret); | ||
| ASSERT_NO_MSG(0); |
There was a problem hiding this comment.
Suggested change
| ASSERT_NO_MSG(0); | |
| __ASSERT_NO_MSG(0); |
?
There was a problem hiding this comment.
Typo in commit message for drivers: ethernet: stm32: clean HAL_ETH_{Set|Get}DMAError() value test
retrun --> return
There was a problem hiding this comment.
and I guess nvm, it returns a u32test against 0 ==> against HAL_OK too
Add missing test of some HAL functions return value Signed-off-by: Etienne Carriere <[email protected]>
Clean tests on HAL_ETH_SetDMAError() and HAL_ETH_GetDMAError() return value to explicitly test against 0. Signed-off-by: Etienne Carriere <[email protected]>
Add missing empty line between local variable definitions and instructions in eth_stm32_set_mac_config(). Signed-off-by: Etienne Carriere <[email protected]>
Correct mdio_stm32_read() and mdio_stm32_write() to return a valid errno instead of mixing HAL return values and errno return values. Signed-off-by: Etienne Carriere <[email protected]>
etienne-lms
force-pushed
the
stm32-hal-ret-eth
branch
from
1eba6b1 to
07f54a5
Compare
|
juickar
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing test of some HAL functions return value in stm32 ethernet drivers.
Correct
mdio_stm32_read()andmdio_stm32_write()to return a valid errno instead of mixing HAL return values anderrnoreturn values.Plus some minor coding style issues fixes.