arch: riscv: Remove early MPRV catch-all in pmp_init #97314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the temporary PMP entry for MPRV catch-all and the setting of MSTATUS_MPRV from the early `z_riscv_pmp_init` function. This early, broad catch-all setup is not strictly necessary. The required MPRV catch-all configuration for stack protection in multithreading scenarios is already handled within the `z_riscv_pmp_stackguard_prepare` function. This function is called during thread creation, providing a more localized and appropriate context for setting up thread-specific stack guard PMP entries, including the MPRV catch-all. This change consolidates the stack guard related PMP setup logic within the thread creation path. Signed-off-by: Firas Sammoura <[email protected]>
zephyrbot
requested review from
VynDragon,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
masz-nordic,
mgielda,
npitre,
tgorochowik and
ycsin
|
|
Before the scheduler starts, each core uses its own IRQ stack during kernel initialization.
This is necessary to ensure kernel initialization doesn’t overflow. Update: The setup mstatus.MPRV and catch all entry is necessary for PMP non-lock entry for kernel initialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the temporary PMP entry for MPRV catch-all and the setting of MSTATUS_MPRV from the early
z_riscv_pmp_initfunction.This early, broad catch-all setup is not strictly necessary. The required MPRV catch-all configuration for stack protection in multithreading scenarios is already handled within the
z_riscv_pmp_stackguard_preparefunction. This function is called during thread creation, providing a more localized and appropriate context for setting up thread-specific stack guard PMP entries, including the MPRV catch-all.This change consolidates the stack guard related PMP setup logic within the thread creation path.