riscv: pmp: Add macro to convert DT memory attributes to PMP permissions #97499
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Tests
zephyrbot
requested review from
VynDragon,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
masz-nordic,
mgielda,
nashif,
npitre,
tgorochowik and
ycsin
fsammoura1980
force-pushed
the
dt_mem_riscv
branch
2 times, most recently
from
483a878 to
a0979ce
Compare
jimmyzhe
reviewed
Oct 15, 2025
Comment on lines
+12
to
+16
| #define DT_MEM_RISCV_TO_PMP_PERM(dt_attr) ( \ | ||
| (((dt_attr) & DT_MEM_RISCV_TYPE_IO_R) ? PMP_R : 0) | \ | ||
| (((dt_attr) & DT_MEM_RISCV_TYPE_IO_W) ? PMP_W : 0) | \ | ||
| (((dt_attr) & DT_MEM_RISCV_TYPE_IO_X) ? PMP_X : 0)) | ||
|
|
fsammoura1980
force-pushed
the
dt_mem_riscv
branch
from
a0979ce to
f7d8712
Compare
fsammoura1980
force-pushed
the
dt_mem_riscv
branch
2 times, most recently
from
c0b6290 to
b4577da
Compare
Introduce the DT_MEM_RISCV_TO_PMP_PERM macro to translate Device Tree RISC-V memory attributes (DT_MEM_RISCV_TYPE_IO_R, DT_MEM_RISCV_TYPE_IO_W, DT_MEM_RISCV_TYPE_IO_X) into their corresponding RISC-V PMP permission bits (PMP_R, PMP_W, PMP_X). This allows for a clear and standardized way to define PMP regions based on Device Tree properties. Added a test suite for RISC-V PMP utilities, including a test case to verify the correctness of the DT_MEM_RISCV_TO_PMP_PERM macro across various attribute combinations. Signed-off-by: Firas Sammoura <[email protected]>
fsammoura1980
force-pushed
the
dt_mem_riscv
branch
from
b4577da to
363b3f7
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
DT_MEM_RISCV_TO_PMP_PERMmacro to translate Device TreeRISC-Vmemory attributes (DT_MEM_RISCV_TYPE_IO_R,DT_MEM_RISCV_TYPE_IO_W,DT_MEM_RISCV_TYPE_IO_X) into their corresponding RISC-V PMP permission bits (PMP_R,PMP_W,PMP_X).This allows for a clear and standardized way to define PMP regions based on Device Tree properties.
Added a test suite for RISC-V PMP utilities, including a test case to verify the correctness of the
DT_MEM_RISCV_TO_PMP_PERMmacro across various attribute combinations.