Skip to content

drivers: modem: sim7080: Fix two issues detected at build time in CI #97707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2025
Merged

drivers: modem: sim7080: Fix two issues detected at build time in CI #97707

merged 3 commits into from
Oct 16, 2025

Conversation

aescolar
Copy link
Member

@aescolar aescolar commented Oct 16, 2025 •
edited
Loading 

drivers: modem: sim7080: Fix invalid call to strtok_r

The second parameter to strtok_r cannot be null.
It is the separator strtok is meant to search for, and it is
not kept anywhere in the saved state (the saved state
is just a pointer to the next piece of the original string).


drivers: modem: sim7080: Fix missing prototype of strtok_r

strtok_r is a POSIX extension of string.h. To ensure this C library
header provides the prototype we need to define _POSIX_C_SOURCE.
So let's do so.

drivers: modem: sim7080: Remove orphan file

drivers/modem/simcom-sim7080.c is not built.
And the author indicates it was added to the tree in error.
Let's remove it.

Related #94929

@aescolar
drivers: modem: sim7080: Fix missing prototype of strtok_r
6e1249e 
strtok_r is a POSIX extension of string.h. To ensure this C library
header provides the prototype we need to define _POSIX_C_SOURCE.
So let's do so.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
@aescolar
drivers: modem: sim7080: Fix invalid call to strtok_r
5a7853b 
The second parameter to strtok_r cannot be null.
It is the separator strtok is meant to search for, and it is
not kept anywhere in the saved state (the saved state
is just a pointer to the next piece of the original string).

Signed-off-by: Alberto Escolar Piedras <[email protected]>
@aescolar aescolar changed the title Simcom drivers: modem: sim7080: Fix two issues detected at build time in CI Oct 16, 2025
@aescolar aescolar requested a review from jhedberg October 16, 2025 12:11
@jhedberg jhedberg requested a review from cfriedt October 16, 2025 12:12
@aescolar
Copy link
Member Author

CC @lgehreke

@aescolar aescolar requested review from rerickson1 and removed request for cfriedt October 16, 2025 12:13
@aescolar aescolar marked this pull request as ready for review October 16, 2025 12:13
@aescolar aescolar requested a review from cfriedt October 16, 2025 12:13
@jhedberg jhedberg added the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Oct 16, 2025
jhedberg
jhedberg previously approved these changes Oct 16, 2025
View reviewed changes
lgehreke
lgehreke suggested changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@lgehreke lgehreke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also delete drivers/modem/simcom-sim7080.c. This was re-added through a faulty rebase

@aescolar
drivers: modem: sim7080: Remove orphan file
f561efe 
drivers/modem/simcom-sim7080.c is not built.
And the author indicates it was added to the tree in error.
Let's remove it.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jhedberg jhedberg merged commit 499f23f into zephyrproject-rtos:main Oct 16, 2025
30 checks passed
@aescolar aescolar deleted the simcom branch October 16, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhedberg jhedberg jhedberg approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@rerickson1 rerickson1 rerickson1 approved these changes

@cfriedt cfriedt Awaiting requested review from cfriedt

@mniestroj mniestroj Awaiting requested review from mniestroj

@bjarki-andreasen bjarki-andreasen Awaiting requested review from bjarki-andreasen

+1 more reviewer

@lgehreke lgehreke lgehreke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rerickson1 rerickson1

Labels

area: Modem Drivers Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aescolar @jhedberg @henrikbrixandersen @rerickson1 @lgehreke @zephyrbot