Add description for nxp,mcux-edma 'dma-requests' and 'dma-channels' #97755
Conversation
zephyrbot
added
area: DMA
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
butok,
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108 and
teburd
|
|
||
| edma0: dma-controller@80000 { | ||
| #dma-cells = <2>; | ||
| compatible = "nxp,mcux-edma"; |
There was a problem hiding this comment.
This PR LGTM, but it should be split in 2 commits:
commit 1 - adds description for dma-requests and dma-channels;
commit 2 - fixes dma-req values, which should also have a Fixes tag since those values were incorrect.
There was a problem hiding this comment.
Hello @iuliana-prodan, thanks for your suggestion, I have updated, please review, thanks!
There was a problem hiding this comment.
From the commit message, I understand that you've changed the meaning of dma-requests. However, you've only updated the values in nxp_mcxn23x_common.dtsi and nxp_mcxnx4x_common.dtsi.
The dma-requests property is used in multiple .dtsi files for NXP platforms:
dts/arm/nxp/nxp_rt11xx.dtsi:1042: dma-requests = <208>;
dts/arm/nxp/nxp_rt11xx.dtsi:1061: dma-requests = <208>;
dts/arm/nxp/nxp_rt118x.dtsi:1260: dma-requests = <39>;
dts/arm/nxp/nxp_rt118x.dtsi:1279: dma-requests = <222>;
dts/arm/nxp/nxp_rt7xx_cm33_cpu0.dtsi:172: dma-requests = <105>;
dts/arm/nxp/nxp_rt7xx_cm33_cpu0.dtsi:187: dma-requests = <105>;
dts/arm/nxp/nxp_s32z27x_r52.dtsi:1154: dma-requests = <64>;
dts/arm/nxp/nxp_s32z27x_r52.dtsi:1199: dma-requests = <64>;
dts/arm/nxp/nxp_s32z27x_r52.dtsi:1228: dma-requests = <64>;
dts/arm/nxp/nxp_s32z27x_r52.dtsi:1257: dma-requests = <64>;
dts/arm/nxp/nxp_mcxn23x_common.dtsi:501: dma-requests = <94>;
dts/arm/nxp/nxp_mcxn23x_common.dtsi:517: dma-requests = <94>;
dts/arm/nxp/nxp_mcxnx4x_common.dtsi:598: dma-requests = <117>;
dts/arm/nxp/nxp_mcxnx4x_common.dtsi:614: dma-requests = <117>;
dts/arm/nxp/nxp_mcxw7x_common.dtsi:400: dma-requests = <64>;
dts/arm/nxp/nxp_s32k344_m7.dtsi:665: dma-requests = <64>;
dts/arm/nxp/nxp_imx95_m7.dtsi:178: dma-requests = <92>;
dts/arm/nxp/nxp_mcxaxx6_common.dtsi:291: dma-requests = <131>;
dts/arm/nxp/nxp_mcxa156.dtsi:253: dma-requests = <86>;
dts/arm/nxp/nxp_k8x.dtsi:432: dma-requests = <64>;
dts/arm/nxp/nxp_ke1xf.dtsi:104: dma-requests = <64>;
dts/arm/nxp/nxp_rt10xx.dtsi:952: dma-requests = <128>;
dts/arm/nxp/nxp_ke1xz.dtsi:497: dma-requests = <64>;
dts/arm/nxp/nxp_k6x.dtsi:529: dma-requests = <64>;
dts/arm/nxp/nxp_mcxa153.dtsi:79: dma-requests = <66>;
dts/xtensa/nxp/nxp_imxrt700_hifi4.dtsi:232: dma-requests = <105>;
So, this change is a bit confusing.
If the previous values were incorrect only in these two files, then this should be treated as a fix, and a Fixes tag should be added.
Otherwise, if the meaning of dma-requests has changed globally (e.g., now representing the maximum number of DMA request sources), then all relevant .dtsi files should be reviewed and updated accordingly to ensure consistency.
There was a problem hiding this comment.
- I did not changed 'dma-requests' meaning globally. I just add description for it.
- I fixed incorrect 'dma-requests' value in dts/arm/nxp/nxp_mcxn23x_common.dtsi and dts/arm/nxp/nxp_mcxnx4x_common.dtsi. I wrongly changed these values in correct mcxn23x and mcxnx4x edma properties information #97389.
- Only these two .dtsi files need to be fixed.
Added description for 'dma-requests' and 'dma-channels' in dts/bindings/dma/nxp,mcux-edma.yaml. Signed-off-by: Zhaoxiang Jin <[email protected]>
ZhaoxiangJin
force-pushed
the
fix-dma-request-issue
branch
from
bd9fe4f to
7b24c47
Compare
ZhaoxiangJin
added
the
Trivial
ZhaoxiangJin
force-pushed
the
fix-dma-request-issue
branch
from
7b24c47 to
3e7647c
Compare
Fixes incorrect 'dma-requests' value in dts/arm/nxp/nxp_mcxn23x_common.dtsi and dts/arm/nxp/nxp_mcxnx4x_common.dtsi. The 'dma-requests' indicates the maximum value of the DMA request sources (slots) index supported by DMAMUX rather than the number of request sources. Fixes: zephyrproject-rtos#97389 (which introduced the incorrect values) Signed-off-by: Zhaoxiang Jin <[email protected]>
ZhaoxiangJin
force-pushed
the
fix-dma-request-issue
branch
from
3e7647c to
39e0648
Compare
|
6 participants
Added description for dma-requests and dma-channels in dts/bindings/dma/nxp,mcux-edma.yaml.
Fixed dma-requests value in dts/arm/nxp/nxp_mcxn23x_common.dtsi and dts/arm/nxp/nxp_mcxnx4x_common.dtsi. The 'dma-requests' indicates the maximum value of the DMA request sources (slots) index supported by DMAMUX rather than the number of request sources.