Skip to content

Add description for nxp,mcux-edma 'dma-requests' and 'dma-channels' #97755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Add description for nxp,mcux-edma 'dma-requests' and 'dma-channels' #97755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a1caae
dts: nxp,mcux-edma: Added description for properties
ZhaoxiangJin Oct 17, 2025
39e0648
dts: nxp_mcxnxxx: Fixes 'dma-requests' incorrect value
ZhaoxiangJin Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dts/arm/nxp/nxp_mcxn23x_common.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@
compatible = "nxp,mcux-edma";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR LGTM, but it should be split in 2 commits:
commit 1 - adds description for dma-requests and dma-channels;
commit 2 - fixes dma-req values, which should also have a Fixes tag since those values were incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @iuliana-prodan, thanks for your suggestion, I have updated, please review, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the commit message, I understand that you've changed the meaning of dma-requests. However, you've only updated the values in nxp_mcxn23x_common.dtsi and nxp_mcxnx4x_common.dtsi.
The dma-requests property is used in multiple .dtsi files for NXP platforms:

dts/arm/nxp/nxp_rt11xx.dtsi:1042:			dma-requests = <208>;
dts/arm/nxp/nxp_rt11xx.dtsi:1061:			dma-requests = <208>;
dts/arm/nxp/nxp_rt118x.dtsi:1260:		dma-requests = <39>;
dts/arm/nxp/nxp_rt118x.dtsi:1279:		dma-requests = <222>;
dts/arm/nxp/nxp_rt7xx_cm33_cpu0.dtsi:172:		dma-requests = <105>;
dts/arm/nxp/nxp_rt7xx_cm33_cpu0.dtsi:187:		dma-requests = <105>;
dts/arm/nxp/nxp_s32z27x_r52.dtsi:1154:			dma-requests = <64>;
dts/arm/nxp/nxp_s32z27x_r52.dtsi:1199:			dma-requests = <64>;
dts/arm/nxp/nxp_s32z27x_r52.dtsi:1228:			dma-requests = <64>;
dts/arm/nxp/nxp_s32z27x_r52.dtsi:1257:			dma-requests = <64>;
dts/arm/nxp/nxp_mcxn23x_common.dtsi:501:		dma-requests = <94>;
dts/arm/nxp/nxp_mcxn23x_common.dtsi:517:		dma-requests = <94>;
dts/arm/nxp/nxp_mcxnx4x_common.dtsi:598:		dma-requests = <117>;
dts/arm/nxp/nxp_mcxnx4x_common.dtsi:614:		dma-requests = <117>;
dts/arm/nxp/nxp_mcxw7x_common.dtsi:400:		dma-requests = <64>;
dts/arm/nxp/nxp_s32k344_m7.dtsi:665:			dma-requests = <64>;
dts/arm/nxp/nxp_imx95_m7.dtsi:178:			dma-requests = <92>;
dts/arm/nxp/nxp_mcxaxx6_common.dtsi:291:			dma-requests = <131>;
dts/arm/nxp/nxp_mcxa156.dtsi:253:			dma-requests = <86>;
dts/arm/nxp/nxp_k8x.dtsi:432:			dma-requests = <64>;
dts/arm/nxp/nxp_ke1xf.dtsi:104:			dma-requests = <64>;
dts/arm/nxp/nxp_rt10xx.dtsi:952:			dma-requests = <128>;
dts/arm/nxp/nxp_ke1xz.dtsi:497:			dma-requests = <64>;
dts/arm/nxp/nxp_k6x.dtsi:529:			dma-requests = <64>;
dts/arm/nxp/nxp_mcxa153.dtsi:79:			dma-requests = <66>;
dts/xtensa/nxp/nxp_imxrt700_hifi4.dtsi:232:		dma-requests = <105>;

So, this change is a bit confusing.

If the previous values were incorrect only in these two files, then this should be treated as a fix, and a Fixes tag should be added.
Otherwise, if the meaning of dma-requests has changed globally (e.g., now representing the maximum number of DMA request sources), then all relevant .dtsi files should be reviewed and updated accordingly to ensure consistency.

Copy link
Contributor Author

@ZhaoxiangJin ZhaoxiangJin Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I did not changed 'dma-requests' meaning globally. I just add description for it.
  2. I fixed incorrect 'dma-requests' value in dts/arm/nxp/nxp_mcxn23x_common.dtsi and dts/arm/nxp/nxp_mcxnx4x_common.dtsi. I wrongly changed these values in correct mcxn23x and mcxnx4x edma properties information #97389.
  3. Only these two .dtsi files need to be fixed.

nxp,version = <4>;
dma-channels = <16>;
dma-requests = <94>;
dma-requests = <119>;

reg = <0x80000 0x1000>;
interrupts = <1 0>, <2 0>, <3 0>, <4 0>,
Expand All @@ -514,7 +514,7 @@
compatible = "nxp,mcux-edma";
nxp,version = <4>;
dma-channels = <8>;
dma-requests = <94>;
dma-requests = <119>;

reg = <0xa0000 0x1000>;
interrupts = <77 0>, <78 0>, <79 0>, <80 0>,
Expand Down
4 changes: 2 additions & 2 deletions dts/arm/nxp/nxp_mcxnx4x_common.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@
compatible = "nxp,mcux-edma";
nxp,version = <4>;
dma-channels = <16>;
dma-requests = <117>;
dma-requests = <121>;

reg = <0x80000 0x1000>;
interrupts = <1 0>, <2 0>, <3 0>, <4 0>,
Expand All @@ -611,7 +611,7 @@
compatible = "nxp,mcux-edma";
nxp,version = <4>;
dma-channels = <16>;
dma-requests = <117>;
dma-requests = <121>;

reg = <0xa0000 0x1000>;
interrupts = <77 0>, <78 0>, <79 0>, <80 0>,
Expand Down
8 changes: 8 additions & 0 deletions dts/bindings/dma/nxp,mcux-edma.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,17 @@ properties:

dma-channels:
required: true
description: |
Specifies the number of DMA channels supported by the controller.
This value is used to validate the channel number provided in the
DMA specifier.

dma-requests:
required: true
description: |
Indicates the maximum value of the DMA request sources (slots) index supported by
DMAMUX. This value is used to validate the request source index provided in the
DMA specifier.

dmamux-reg-offset:
type: int
Expand Down