Skip to content

Infineon T2G Body High boards support: KIT_T2G_B_H_LITE and KIT_T2G_B_H_EVK #97771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Infineon T2G Body High boards support: KIT_T2G_B_H_LITE and KIT_T2G_B_H_EVK #97771

wants to merge 4 commits into from
+1,461 −21

Conversation

@yurvyn
Copy link

@yurvyn yurvyn commented Oct 17, 2025

  • Added new boards support: KIT_T2G_B_H_LITE and KIT_T2G_B_H_EVK.
  • Added core selection to CYT4BF (T2G_B_H) MPNs defined in SoC XMC7200.

@zephyrbot zephyrbot added area: Tests Issues related to a particular existing or missing test platform: Infineon Infineon Technologies AG area: Boards/SoCs area: ARM ARM (32-bit) Architecture labels Oct 17, 2025
@yurvyn yurvyn force-pushed the kit_t2g_b_h_boards branch from 0bf9080 to 7461a5f Compare October 17, 2025 08:22
nordicjm
nordicjm requested changes Oct 17, 2025
View reviewed changes
soc/infineon/cat1c/xmc7200/Kconfig.soc Outdated

# SOC Cortex M7 CPUs
config SOC_CPU_XMC7200_M7_0
bool "This option signifies the use of a Cortex-M7_0 CPU"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no prompts on these symbols, also why does it not select the other symbols? And why is this named SOC_CPU_? Non compliant with soc porting guide

Copy link
Author

@yurvyn yurvyn Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed prompts.
Renamed to SOC_XMC7200_CORE_NAME_M7_0 and SOC_XMC7200_CORE_NAME_M7_1.
This symbol does not select other symbols because it is used only in CMakeLists.txt:
zephyr_compile_definitions_ifdef(CONFIG_SOC_XMC7200_CORE_NAME_M7_0 CORE_NAME_CM7_0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not mark conversations as resolved when they are not resolved. That code needs to go, frankly, you are providing global definitions pointlessly to all files, if you build hello world then why does hello world's main.c need that? Remove the global definition, if a HAL library needs it then add it using the zephyr_library_* function in the area that creates it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurvyn - Please look at the below comments for relevant discussion on the same,
#95874 (comment)
#95874 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
Moved CORE_NAME_CM7_* defines to modules/hal_infineon using zephyr_library_*.

@nordicjm nordicjm requested a review from kartben October 17, 2025 10:14
@wearyzen wearyzen removed their assignment Oct 17, 2025
@yurvyn yurvyn force-pushed the kit_t2g_b_h_boards branch from 7461a5f to c415e86 Compare October 17, 2025 13:17
@yurvyn yurvyn force-pushed the kit_t2g_b_h_boards branch from c415e86 to 4d5654c Compare October 17, 2025 13:21
@yurvyn yurvyn requested a review from nordicjm October 17, 2025 14:36
nordicjm
nordicjm requested changes Oct 20, 2025
View reviewed changes
@yurvyn yurvyn force-pushed the kit_t2g_b_h_boards branch from 4d5654c to 5e34235 Compare October 20, 2025 08:24
@yurvyn yurvyn requested a review from nordicjm October 20, 2025 09:47
@sreeramIfx sreeramIfx added this to the v4.3.0 milestone Oct 21, 2025
@parthitce parthitce mentioned this pull request Oct 22, 2025
Open
@yurvyn
Copy link
Author

yurvyn commented Oct 22, 2025

@nordicjm, @sreeramIfx
Please approve the pull request.

kartben
kartben previously approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation bits look OK - a bit of a shame that the quality of the board pictures is so low but I couldn't really find better alternatives online :/

sreeramIfx
sreeramIfx previously approved these changes Oct 22, 2025
View reviewed changes
@kartben kartben assigned sreeramIfx and unassigned wearyzen Oct 23, 2025
@kartben
Copy link
Contributor

kartben commented Oct 23, 2025

assigning to sreeramIfx as Infineon platform maintainer

nordicjm
nordicjm requested changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not addressed

@yurvyn yurvyn requested a review from nordicjm October 24, 2025 08:51
Yuriy Vynnychek added 2 commits October 24, 2025 23:16
dts: infineon: xmc7200: fix wrong Flash and SRAM namings
56697d6 
Fix wrong case when Flash was called "data" and SRAM was called "code".
Rename Flash to "code" and SRAM to "data".

Signed-off-by: Yuriy Vynnychek <[email protected]>
soc: infineon: xmc7200: extend CYT4BFxx MPNs support
54b2a09 
- Add Cortex M0+, M7(0) and M7(1) selection.
- Add TEQFP_176 and BGA_320 package support.

Signed-off-by: Yuriy Vynnychek <[email protected]>
@yurvyn yurvyn dismissed stale reviews from sreeramIfx and kartben via f88083e October 24, 2025 20:32
@yurvyn yurvyn force-pushed the kit_t2g_b_h_boards branch from 5e34235 to f88083e Compare October 24, 2025 20:32
Yuriy Vynnychek added 2 commits October 24, 2025 23:43
board: infineon: kit_t2g_b_h_lite: new board basic support
9afe1c4 
Add new board basic support: dts, kconfig, defconfig, openocd and doc.

Signed-off-by: Yuriy Vynnychek <[email protected]>
board: infineon: kit_t2g_b_h_evk: new board basic support
a646b19 
Add new board basic support: dts, kconfig, defconfig, openocd and doc.

Signed-off-by: Yuriy Vynnychek <[email protected]>
@yurvyn yurvyn force-pushed the kit_t2g_b_h_boards branch from f88083e to a646b19 Compare October 24, 2025 20:46
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sreeramIfx sreeramIfx sreeramIfx left review comments

@kartben kartben kartben left review comments

@ithinuel ithinuel Awaiting requested review from ithinuel

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@mcatee-infineon mcatee-infineon Awaiting requested review from mcatee-infineon

@nashif nashif Awaiting requested review from nashif

@parthitce parthitce Awaiting requested review from parthitce

@stephanosio stephanosio Awaiting requested review from stephanosio

@talih0 talih0 Awaiting requested review from talih0

@wearyzen wearyzen Awaiting requested review from wearyzen

@nordicjm nordicjm Awaiting requested review from nordicjm

Requested changes must be addressed to merge this pull request.

Assignees

@sreeramIfx sreeramIfx

Labels

area: ARM ARM (32-bit) Architecture area: Boards/SoCs area: Tests Issues related to a particular existing or missing test platform: Infineon Infineon Technologies AG

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@yurvyn @kartben @nordicjm @sreeramIfx @zephyrbot @wearyzen