Skip to content

Conversation

AzharMCHP
Copy link
Contributor

This PR adds initial support for Microchip’s PIC32CZ CA family of SoCs, along with board support for the PIC32CZ CA80 Curiosity Ultra development board (EV51S73A). It includes the basic SoC integration, devicetree files, and minimal configuration needed to bring up the board with a working blinky.

Comment on lines 7 to 8
/* Memory configuration: Flash size, RAM Size and Data Flash size for 1051 memory variants */

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superfluous comment in every file? The filename indicates that. Remove from all files

Copy link
Contributor Author

@AzharMCHP AzharMCHP Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nordicjm for the comment.
I can keep the bare minimum text as the comment.
As this file name indication varies for certain other dtsi files

For eg:
[pic32cz_1051_ca.dtsi] - memory variant 1051
[pic32cz_ca_100.dtsi] - pin count 100

So a simple comment like this will be helpful I guess - " /* 1051 memory variants */ "

Shall I make that change in all files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need comments in all the files, what other soc has a comment in every file like that? The point in a comment is to allow someone to understand the way something works or why a specific thing was done, if all it does is describe what is already known by looking at e.g. the filename then the comment is worthless. Do we have comments in board README files e.g.

# this is the README for the native_sim board

in boards/native_sim/docs/index.rst ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nordicjm for the clarification, I will remove all unwanted comments from these files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as per your comment @nordicjm

Copy link
Contributor

@NhMchp NhMchp Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AzharMCHP , I reviewed the removal of comments. I agree with @nordicjm about removing redundant info as comments. But, how are you now differentiating pin variant configuration and memory variant configuration? It is not evident from file name

@NhMchp NhMchp added the platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) label Oct 17, 2025
Adds common and SoC-specific .dtsi files for the Microchip
PIC32CZ CA80 CA90 and CA91 family. These files define core
peripherals, address maps, and interrupt controller structure
shared across the PIC32CZ CA80 9x variants.

Signed-off-by: Mohamed Azhar <[email protected]>
Adds initial SoC-level support for the Microchip
PIC32CZ CA80/9x series, including SoC definition files.

Signed-off-by: Mohamed Azhar <[email protected]>
Add initial support for the PIC32CZ CA80 Curiosity Ultra Development Board
Product page: https://www.microchip.com/en-us/development-tool/ev51s73a

Signed-off-by: Mohamed Azhar <[email protected]>
@AzharMCHP AzharMCHP force-pushed the pic32cz_ca_minimal_support branch from 4fe186c to 9c443ad Compare October 17, 2025 14:49
Copy link

@AzharMCHP AzharMCHP marked this pull request as ready for review October 17, 2025 15:31
@AzharMCHP AzharMCHP requested a review from nordicjm October 17, 2025 15:31
@NhMchp NhMchp added this to the v4.3.0 milestone Oct 19, 2025

2. Connect the Board

- Connect the `J32 Debug Probe <https://www.microchip.com/en-us/development-tool/dv164232>`_ to the board's **CORTEX DEBUG** header.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Mouser Electronics, DigiKey, Microchip Direct, indicate DV164232 as Obsolete / End of life / Out of stock.
Is there any debug probe that supports PIC32CZ CA and is available for purchase?

@nordicjm nordicjm requested a review from kartben October 20, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs platform: Microchip MEC Microchip MEC Platform platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants