drivers: i3c: npcx: add device only when IBI enable succeeds #97962
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the device is added to the list only if the ENEC I3C transaction succeeds. Adding the device before enabling IBI may cause IBI retry failures due to the device already being present in the list. Signed-off-by: Alvis Sun <[email protected]>
alvsun
force-pushed
the
npcx_i3c_ibien_fix
branch
from
d29a468 to
d885a98
Compare
zephyrbot
requested review from
ChiHuaL,
MulinChao,
TomChang19,
XenuIsWatching,
dcpleung,
fabiobaltieri and
keith-zephyr
|
|
Hi @albertofloyd |
fabiobaltieri
approved these changes
Oct 21, 2025
LGTM |
albertofloyd
approved these changes
Oct 21, 2025
nashif
approved these changes
Oct 21, 2025
ChiHuaL
approved these changes
Oct 22, 2025
XenuIsWatching
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the device is added to the list only if the ENEC I3C transaction succeeds.
Adding the device before enabling IBI may cause IBI retry failures due to the device already being present in the list.
Fixes #97219