Skip to content

drivers: i3c: npcx: add device only when IBI enable succeeds #97962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −9
Open

drivers: i3c: npcx: add device only when IBI enable succeeds #97962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions drivers/i3c/i3c_npcx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,18 +1877,20 @@ static int npcx_i3c_ibi_enable(const struct device *dev, struct i3c_device_desc
idx = 0;
}

data->ibi.addr[idx] = target->dynamic_addr;
data->ibi.num_addr += 1U;

npcx_i3c_ibi_rules_setup(data, inst);

/* Enable target IBI event by ENEC command */
i3c_events.events = I3C_CCC_EVT_INTR;
ret = i3c_ccc_do_events_set(target, true, &i3c_events);
if (ret != 0) {
LOG_ERR("Error sending IBI ENEC for 0x%02x (%d)", target->dynamic_addr, ret);
goto out_ibi_enable;
}

/* Update IBI address table after CCC command succeeds */
data->ibi.addr[idx] = target->dynamic_addr;
data->ibi.num_addr += 1U;

npcx_i3c_ibi_rules_setup(data, inst);

out_ibi_enable:
if (data->ibi.num_addr > 0U) {
/*
Expand Down Expand Up @@ -1930,19 +1932,21 @@ static int npcx_i3c_ibi_disable(const struct device *dev, struct i3c_device_desc
/* Disable controller interrupt while we configure IBI rules. */
inst->MINTCLR = BIT(NPCX_I3C_MINTCLR_TGTSTART);

/* Clear the ibi rule data */
data->ibi.addr[idx] = 0U;
data->ibi.num_addr -= 1U;

/* Disable disable target IBI */
i3c_events.events = I3C_CCC_EVT_INTR;
ret = i3c_ccc_do_events_set(target, false, &i3c_events);
if (ret != 0) {
LOG_ERR("Error sending IBI DISEC for 0x%02x (%d)", target->dynamic_addr, ret);
goto out_ibi_disable;
}

/* Clear the ibi rule data after CCC command succeeds */
data->ibi.addr[idx] = 0U;
data->ibi.num_addr -= 1U;

npcx_i3c_ibi_rules_setup(data, inst);

out_ibi_disable:
if (data->ibi.num_addr > 0U) {
/*
* Enable controller to raise interrupt when a target
Expand Down