Skip to content

Conversation

@henrikbrixandersen
Copy link
Member

Remove false Z_TEST_SKIP_IFNDEF(CONFIG_CAN_MANUAL_RECOVERY_MODE) from the CAN test suites.

The can_recover() API function must always be tested and CONFIG_CAN_MANUAL_RECOVERY_MODE is enabled in the test suites' prj.conf.

The test suites already rely on the capabilities of the CAN controller driver for determining how to validate the API contract.

… skip

Remove false Z_TEST_SKIP_IFNDEF(CONFIG_CAN_MANUAL_RECOVERY_MODE) from the
CAN classic test suite.

The can_recover() API function must always be tested and
CONFIG_CAN_MANUAL_RECOVERY_MODE is enabled in the test suite prj.conf.

The test suite already relies on the capabilities of the CAN controller
driver for determining how to validate the API contract.

Signed-off-by: Henrik Brix Andersen <[email protected]>
Remove false Z_TEST_SKIP_IFNDEF(CONFIG_CAN_MANUAL_RECOVERY_MODE) from the
CAN shell test suite.

The cmd_can_recover() shell function must always be tested and
CONFIG_CAN_MANUAL_RECOVERY_MODE is enabled in the test suite
prj.conf.

The test suite already relies on the capabilities of the CAN controller
driver for determining how to validate the API contract.

Signed-off-by: Henrik Brix Andersen <[email protected]>
@henrikbrixandersen henrikbrixandersen added this to the v4.3.0 milestone Oct 22, 2025
@henrikbrixandersen henrikbrixandersen added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Oct 22, 2025
@zephyrbot zephyrbot added area: CAN area: Tests Issues related to a particular existing or missing test labels Oct 22, 2025
@sonarqubecloud
Copy link

@cfriedt cfriedt merged commit 9f425d9 into zephyrproject-rtos:main Oct 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: CAN area: Tests Issues related to a particular existing or missing test Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants