MSPM0 MSPM0G51xx support by d-philpot · Pull Request #99344 · zephyrproject-rtos/zephyr

d-philpot · 2025-11-13T21:30:45Z

This PR adds support for the MSPM0G51xx family of SoCs. Adds necessary dts, kconfig, and board files for this family. Also includes updates to the serial driver to account the new communication peripheral in this family: UNICOMM.

In flight PR includes necessary SDK and pinctrl hal changes. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

Adds relevant SOC defines for MSPM0G51xx family. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

Includes devices tree files for MSPM0G51xx family. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

Adds dts, yaml, and support files for the MSPM0G5187 launchpad. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

Adding UNICOMM_Inst_Regs to typedef to avoid compliance errors regarding consistent spacing '*' Signed-off-by: Dylan Philpot <d-philpot@ti.com>

UART on the MSPM0G51xx family is part of a singular comm peripheral (UNICOMM). Functionality is the same but requires additional overhead of managing the register type and include paths. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

Adds IOMUX look up table for MSPM0G51xx family to GPIO driver. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

github-actions · 2025-11-13T21:33:28Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_ti	zephyrproject-rtos/hal_ti@`cc04902`	zephyrproject-rtos/hal_ti#74	zephyrproject-rtos/hal_ti#74/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

dsseng

thanks, please see some minor comments

dsseng · 2025-11-13T21:38:59Z

dts/arm/ti/mspm0/g/mspm0g5187.dtsi

Everything looks shared with mspm0g5117.dtsi

Could you please consider moving these definitions into a shared file of extend 5187 from 5117

Please disregard this comment if these SoCs will diverge vastly once more peripherals are added in

dsseng · 2025-11-13T21:47:09Z

boards/ti/lp_mspm0g5187/doc/lp_mspm0g5187.webp

I'm not a person responsible for this, but maybe this image is of too high resolution. @kartben should the board image be under ca 500 KiB?

this needs to be about 50KiB or so

^^ still relevant

sonarqubecloud · 2025-11-13T22:22:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nordicjm · 2025-11-14T07:10:30Z

soc/ti/mspm0/Kconfig.soc

+config HAS_MSP_UNICOMM
+	bool


has no place in this file

@nordicjm can you elaborate?

@nordicjm Can you provide more information on this comment?

I think Kconfig.soc should only have SOC_<soc-name> symbols, see https://docs.zephyrproject.org/latest/hardware/porting/soc_porting.html#create-your-soc-directory

nordicjm · 2025-11-14T07:11:17Z

boards/ti/lp_mspm0g5187/doc/lp_mspm0g5187.webp

this needs to be about 50KiB or so

nordicjm · 2025-11-14T07:11:46Z

boards/ti/lp_mspm0g5187/lp_mspm0g5187.dts

+
+	leds {
+		compatible = "gpio-leds";
+		led0: led_0 {


this file is non compliant with the dts requirements

@d-philpot check the compliance errors, there's a tool you can run to autoformat the dts file

lsd-he360 · 2025-11-16T22:26:52Z

drivers/gpio/gpio_mspm0.c

+#if CONFIG_SOC_MSPM0G5187
+static uint8_t gpiob_pincm_lut[NUM_GPIOB_PIN] = {
+	IOMUX_PINCM12, IOMUX_PINCM13, IOMUX_PINCM15, IOMUX_PINCM16, IOMUX_PINCM17,
+	IOMUX_PINCM18, IOMUX_PINCM23, IOMUX_PINCM24, IOMUX_PINCM25, IOMUX_PINCM26,
+	IOMUX_PINCM27, IOMUX_PINCM28, IOMUX_PINCM29, IOMUX_PINCM30, IOMUX_PINCM31,
+	IOMUX_PINCM32, IOMUX_PINCM33, IOMUX_PINCM43, IOMUX_PINCM44, IOMUX_PINCM45,
+	IOMUX_PINCM48, IOMUX_PINCM49, IOMUX_PINCM50, IOMUX_PINCM51, IOMUX_PINCM52,
+	IOMUX_PINCM56
+};


Not necessarily requesting any action at the moment, but I had to make similar updates for port B and port C pins for MSPM0G3519 SOC with 100-pin package. It could get ugly if people just start adding SOC-specific definitions here...

Agree. This keeps expanding for each series. Not nice for longer run, we need better approach.

parthitce

Reorder the commit of serial before using it.

parthitce · 2025-11-20T04:30:45Z

scripts/checkpatch/typedefsfile

 Pwm
 FILE
 NRF_GPIO_Type
+UNICOMM_Inst_Regs


Not related to this PR. IMO this needs to be separate PR

This PR is the first to introduce UNICOMM_Inst_Regs, so I believe it is relevant. The complaince checks will not pass without it.

parthitce · 2025-11-20T04:31:30Z

dts/arm/ti/mspm0/g/mspm0g5115.dtsi

@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: Apache-2.0 */


add copyright, applies to all placed

parthitce · 2025-11-20T04:34:19Z

modules/Kconfig.mspm0

 config USE_MSPM0_DL_UART
 	bool

+config USE_MSPM0_DL_UNICOMM_UART


never used but defined?

It is used in the kconfig of the serial driver to pull in the correct APIs from the hal.

parthitce · 2025-11-20T04:35:11Z

drivers/gpio/gpio_mspm0.c

+#if CONFIG_SOC_MSPM0G5187
+static uint8_t gpiob_pincm_lut[NUM_GPIOB_PIN] = {
+	IOMUX_PINCM12, IOMUX_PINCM13, IOMUX_PINCM15, IOMUX_PINCM16, IOMUX_PINCM17,
+	IOMUX_PINCM18, IOMUX_PINCM23, IOMUX_PINCM24, IOMUX_PINCM25, IOMUX_PINCM26,
+	IOMUX_PINCM27, IOMUX_PINCM28, IOMUX_PINCM29, IOMUX_PINCM30, IOMUX_PINCM31,
+	IOMUX_PINCM32, IOMUX_PINCM33, IOMUX_PINCM43, IOMUX_PINCM44, IOMUX_PINCM45,
+	IOMUX_PINCM48, IOMUX_PINCM49, IOMUX_PINCM50, IOMUX_PINCM51, IOMUX_PINCM52,
+	IOMUX_PINCM56
+};


Agree. This keeps expanding for each series. Not nice for longer run, we need better approach.

fabiobaltieri · 2025-12-17T11:51:12Z

west.yml

        - hal
    - name: hal_ti
-      revision: cc049020152585c4e968b83c084d230234b6d852
+      revision: pull/74/head


hey there's some pending comments on zephyrproject-rtos/hal_ti#74

fabiobaltieri · 2025-12-17T12:02:42Z

soc/ti/mspm0/Kconfig.soc

+config HAS_MSP_UNICOMM
+	bool


I think Kconfig.soc should only have SOC_<soc-name> symbols, see https://docs.zephyrproject.org/latest/hardware/porting/soc_porting.html#create-your-soc-directory

fabiobaltieri · 2025-12-17T12:03:40Z

boards/ti/lp_mspm0g5187/Kconfig.lp_mspm0g5187

+# SPDX-License-Identifier: Apache-2.0
+
+config BOARD_LP_MSPM0G5187
+	select SOC_MSPM0G5187


missing \n at EOF, check your editor config

fabiobaltieri · 2025-12-17T12:04:11Z

boards/ti/lp_mspm0g5187/doc/lp_mspm0g5187.webp

^^ still relevant

fabiobaltieri · 2025-12-17T12:05:20Z

boards/ti/lp_mspm0g5187/lp_mspm0g5187.dts

+
+	leds {
+		compatible = "gpio-leds";
+		led0: led_0 {


@d-philpot check the compliance errors, there's a tool you can run to autoformat the dts file

fabiobaltieri · 2025-12-17T12:07:36Z

drivers/serial/uart_mspm0.c

+	IF_ENABLED(CONFIG_HAS_MSP_UNICOMM,                                     \
+	(static UNICOMM_Inst_Regs uart_mspm0_uc_regs_##index = {               \
+		.inst =  (UNICOMM_Regs *)DT_INST_REG_ADDR(index),                  \
+		.uart = (UNICOMMUART_Regs *)UC_UART_BASE(DT_INST_REG_ADDR(index)), \
+		.fixedMode = DT_CHILD_NUM(DT_PARENT(DT_DRV_INST(index))) == 1,     \
+	};)                                                                    \
+	)											\
+												\
+	static const struct uart_mspm0_config uart_mspm0_cfg_##index = {	\
+		.regs = COND_CODE_1(CONFIG_HAS_MSP_UNICOMM,					\
+			(&uart_mspm0_uc_regs_##index), ((UART_Regs *)DT_INST_REG_ADDR(index))),	\


the \ should be aligned, also the parenthesization is a bit all over, should be something like

IF_ENABLED(CONFIG_HAS_MSP_UNICOMM, ( \ static UNICOMM_Inst_Regs uart_mspm0_uc_regs_##index = { \ .inst = (UNICOMM_Regs *)DT_INST_REG_ADDR(index), \ .uart = (UNICOMMUART_Regs *)UC_UART_BASE(DT_INST_REG_ADDR(index)), \ .fixedMode = DT_CHILD_NUM(DT_PARENT(DT_DRV_INST(index))) == 1, \ }; \ ))

IMO, thogh people have different preferences just keep it coherent with the file if there's any other of those patterns

github-actions · 2026-02-16T00:53:01Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

d-philpot added 7 commits November 13, 2025 14:58

west: update to in flight pr

c6107a0

In flight PR includes necessary SDK and pinctrl hal changes. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

soc: add soc definitions for MSPM0G51xx

35257cd

Adds relevant SOC defines for MSPM0G51xx family. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

dts: add files for MSPM0G51xx family

67c1c80

Includes devices tree files for MSPM0G51xx family. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

boards: add LP_MSPM0G5187 board support

ceab05a

Adds dts, yaml, and support files for the MSPM0G5187 launchpad. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

scripts: checkpatch: add UNICOMM_Inst_Regs

fee99fb

Adding UNICOMM_Inst_Regs to typedef to avoid compliance errors regarding consistent spacing '*' Signed-off-by: Dylan Philpot <d-philpot@ti.com>

serial: update uart driver to account for UNICOMM

0261d5c

UART on the MSPM0G51xx family is part of a singular comm peripheral (UNICOMM). Functionality is the same but requires additional overhead of managing the register type and include paths. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

gpio: update pin LUT for MSPM0G51xx

c296679

Adds IOMUX look up table for MSPM0G51xx family to GPIO driver. Signed-off-by: Dylan Philpot <d-philpot@ti.com>

zephyrbot added area: GPIO platform: TI Texas Instruments area: Linters area: UART Universal Asynchronous Receiver-Transmitter area: Boards/SoCs platform: Texas Instruments MSPM0 labels Nov 13, 2025

zephyrbot requested review from dcpleung, henrikbrixandersen, kartben, keith-zephyr, nashif, pdgendt, ssekar15 and vaishnavachath November 13, 2025 21:32

zephyrbot assigned dcpleung Nov 13, 2025

github-actions bot added manifest manifest-hal_ti DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Nov 13, 2025

dsseng self-requested a review November 13, 2025 21:41

dsseng reviewed Nov 13, 2025

View reviewed changes

nordicjm requested changes Nov 14, 2025

View reviewed changes

lsd-he360 reviewed Nov 16, 2025

View reviewed changes

parthitce requested changes Nov 20, 2025

View reviewed changes

fabiobaltieri assigned d-philpot and unassigned dcpleung Dec 17, 2025

fabiobaltieri reviewed Dec 17, 2025

View reviewed changes

github-actions bot added the Stale label Feb 16, 2026

github-actions bot closed this Mar 3, 2026

Conversation

d-philpot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

dsseng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 13, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parthitce left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants