This repository was archived by the owner on Nov 25, 2025. It is now read-only.
address various issues with the ZLS config middleware #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techatrix
added a commit
to zigtools/zls
that referenced
this pull request
Jul 20, 2025
Depends on ziglang/vscode-zig#442 to work properly in VS Code.
Techatrix
added a commit
to zigtools/zls
that referenced
this pull request
Jul 22, 2025
Depends on ziglang/vscode-zig#442 to work properly in VS Code.
Techatrix
added a commit
to zigtools/zls
that referenced
this pull request
Jul 22, 2025
Depends on ziglang/vscode-zig#442 to work properly in VS Code.
leecannon
referenced
this pull request
in zigtools/zls
Jul 23, 2025
- handle a `ConfigurationParams` with `section == "zls"` - improve handling of the `ConfigurationParams.scopeUri` parameter which may be used by ZLS in the future to handle multi workspace projects - improve handling of nested config options which may be used by ZLS in the future. zigtools/zls#1780
One less dependency.
These changes may matter when there are none or multiple workspace folders.
Techatrix
force-pushed
the
techatrix/zls-config-middleware
branch
from
6b6ef1e to
d881ff7
Compare
Vexu
approved these changes
Jul 23, 2025
Collaborator
Author
|
@Vexu Would it possible to get a new release of the extension so I can make use of this in ZLS? |
Techatrix
added a commit
to zigtools/zls
that referenced
this pull request
Jul 24, 2025
Depends on ziglang/vscode-zig#442 to work properly in VS Code.
Member
Done. |
Techatrix
added a commit
to zigtools/zls
that referenced
this pull request
Jul 26, 2025
Depends on ziglang/vscode-zig#442 to work properly in VS Code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently planning to change how ZLS requests config options using the
workspace/Configurationrequest which has led me to identify some issues with the extension's handling of this request. The extension currently assumes that ZLS will request individual config options instead using a ConfigurationItem withsection == "zls"to request all config options as a single JSON object. With these changes, the extension should be able to handle both strategies.This also has the benefit that it can make supporting config options that are not specified in the
package.jsontrivial without the need forzig.zls.additionalOptions(#182). I plan to open a follow up issue about this.