-
Notifications
You must be signed in to change notification settings - Fork 878
Fixes for the Bosch Room Thermostat II, including a Heating/Cooling toggle. #4344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sopsy
wants to merge
16
commits into
zigpy:dev
Choose a base branch
from
Sopsy:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4344 +/- ##
==========================================
+ Coverage 92.12% 92.15% +0.02%
==========================================
Files 358 358
Lines 11917 11954 +37
==========================================
+ Hits 10979 11016 +37
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
Added some more missing features. |
Fixed conflicts and added the missing features researched with the help of @DerDreschner over at the Z2M side (thanks!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes the missing cooling mode this thermostat has, but is not easily available to be toggled due to ZHA misintepreting "HEATING_ONLY" as something that cannot be toggled to "COOLING_ONLY". Bosch probably means that it does not automatically change to cooling when it's heating only.
It uses the undocumented 0x06 "centralite specific" value, which works perfectly for this thermostat as well.
Adds Imperial/Metric config option for the temperature reading on the thermostat itself.
Moves Operating mode from Diagnostic to Config, so it is easier to change from the UI. In reality Manual is usually the only mode people would like to use with HA, but this change makes it easier to change to that (default on the thermostat is Schedule).
Adds back "Heating demand" that was removed with the fix of ZHA Bosch thermostat shows state as heating while cooling home-assistant/core#151763. It is useful information, and I would not want to remove it completely, rather rename it so ZHA does not get confused.
Adds an entity for outdoor temperature sensor, useful for automations. This is shown in the top right corner of the screen along with a tree icon indicating "outdoors". The default is indeed -327.68C, but as long as the value is never changed, nothing is displayed on the screen. Valid range is -99.9 - 99.9 C. -100C and below is displayed as Lo, and 100C and higher is not displayed at all, so it can be used as a way to remove the number from the screen.
To get rid of the temperature in the corner, the thermostat can be rebooted or the value set to anything over 10 000. After a reboot it's gone, but comes back after the first write to the value.
Adds the NC/NO setting for valves.
Adds the Min/Max cool setpoint limit config.
Adds the external sensor (usually a floor sensor) connection setting.
Adds the Valve status LED setting.
Adds the heater type (underfloor, boiler, radiator, central heating) setting.
According to Bosch documentation and recent research, the meaning is following:
Underfloor heating: 230V relay output.
Boiler: Potential free relay output. (Removed from the Bosch Smart Home app, replaced with Central heating)
Radiator: Radio only.
Central heating: Relay disconnected (not used), everything is controlled by the controller and not the thermostat. Thermostat only reports the heating demand to the controller.
Especially 6, 8 and 10 are crucial for some setups, previously completely preventing using this thermostat without the Bosch Smart Home Controller because they are not changeable from the thermostat itself when it is connected to a Zigbee network.
Additional information
3 visual issues persist that this does not fix. I did not spend too much time trying to figure out how to override the attributes (seemingly not very easy) as they do work, but are just confusing in the UI.
If someone knows how to fix these with just the quirk, I'd be happy to implement.
Device diagnostics
Checklist
pre-commit
checks pass / the code has been formatted using Black