Added ZClient.requiringConfig, which has consistent types across platforms #3727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kalin-Rudnicki
requested review from
987Nabil,
jdegoes,
kyri-petrou and
vigoo
as code owners
✅ Deploy Preview for zio-http ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Kalin-Rudnicki
commented
Oct 6, 2025
|
|
||
| trait ZClientPlatformSpecific { | ||
|
|
||
| def requiringConfig: ZLayer[ZClient.Config, Throwable, Client] = |
Contributor
Author
There was a problem hiding this comment.
I would have ideally like to have called this something like customized or configured, but both of those are already taken by type-mismatching platform-specific overrides. Open to naming suggestions if something else is preferable.
Contributor
There was a problem hiding this comment.
You could do fromConfig, withConfig or even configured, since the new one has no params
987Nabil
force-pushed
the
current/feature/consistent-layers
branch
from
4443ac4 to
e50a84d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
ZClientPlatformSpecificdefines its layers, with layers of the same names but different types on different platforms, is a bit unfortunate for a consuming library which is also cross platform, and does not want to deal with platform-specific things within zio-http.The only layer which has a consistent signature is
default.There is no consistent layer across platforms which has the signature
ZLayer[ZClient.Config, Throwable, Client]. This MR adds such a layer builder.