Skip to content

Added ZClient.requiringConfig, which has consistent types across platforms #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kalin-Rudnicki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added ZClient.requiringConfig, which has consistent types across platforms #3727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion zio-http/js/src/main/scala/zio/http/ZClientPlatformSpecific.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ import zio.http.internal.FetchDriver

trait ZClientPlatformSpecific {

def requiringConfig: ZLayer[ZClient.Config, Throwable, Client] =
Copy link
Contributor Author

@Kalin-Rudnicki Kalin-Rudnicki Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have ideally like to have called this something like customized or configured, but both of those are already taken by type-mismatching platform-specific overrides. Open to naming suggestions if something else is preferable.

Copy link
Contributor

@987Nabil 987Nabil Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could do fromConfig, withConfig or even configured, since the new one has no params

live

def customized: ZLayer[Config with ZClient.Driver[Any, Scope, Throwable], Throwable, Client] = {
implicit val trace: Trace = Trace.empty
ZLayer.scoped {
Expand Down Expand Up @@ -35,7 +38,7 @@ trait ZClientPlatformSpecific {

def default: ZLayer[Any, Throwable, Client] = {
implicit val trace: Trace = Trace.empty
ZLayer.succeed(Config.default) >>> live
ZLayer.succeed(Config.default) >>> requiringConfig
}

}
8 changes: 6 additions & 2 deletions zio-http/jvm/src/main/scala/zio/http/ZClientPlatformSpecific.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ import zio.http.netty.client.NettyClientDriver

trait ZClientPlatformSpecific {

def requiringConfig: ZLayer[ZClient.Config, Throwable, Client] = {
implicit val trace: Trace = Trace.empty
(ZLayer.succeed(NettyConfig.defaultWithFastShutdown) ++ DnsResolver.default) >>> live
}

def customized: ZLayer[Config with ClientDriver with DnsResolver, Throwable, Client] = {
implicit val trace: Trace = Trace.empty
ZLayer.scoped {
Expand Down Expand Up @@ -41,8 +46,7 @@ trait ZClientPlatformSpecific {

def default: ZLayer[Any, Throwable, Client] = {
implicit val trace: Trace = Trace.empty
(ZLayer.succeed(Config.default) ++ ZLayer.succeed(NettyConfig.defaultWithFastShutdown) ++
DnsResolver.default) >>> live
ZLayer.succeed(Config.default) >>> requiringConfig
}

}
Loading