fix: ServerHello.key_share schema definition (SubRecord misuse)#476
Merged
dadrian merged 1 commit intozmap:masterfrom Feb 18, 2026
Merged
fix: ServerHello.key_share schema definition (SubRecord misuse)#476dadrian merged 1 commit intozmap:masterfrom
dadrian merged 1 commit intozmap:masterfrom
Conversation
dadrian
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the schema definition of
server_hello.key_shareinzcrypto_schemas/zcrypto.py.Technical Details
The current implementation defines it as:
"key_share": SubRecord({ CurveID(...) }),.However,
SubRecord(...)expects a dictionary of named subfields. Passing a set-like literal results in a runtime error during schema import:AttributeError: 'set' object has no attribute 'items'(seen in zmap/zgrab2#672 integration tests).This change replaces the incorrect
SubRecord(...)usage with a directCurveID(...)type:"key_share": CurveID(...).CurveIDalready represents the correct structure for TLS NamedGroup values (hex,name,value). Sinceserver_hello.key_shareis a single negotiated group, it should useCurveIDdirectly instead of being wrapped inSubRecord.This bug currently causes
zcrypto_schemasto fail at import time in Python (e.g., during zgrab2 integration tests).Motivation
Attempt to fix the zmap/zgrab2#672 integration tests.