Skip to content

fix: ServerHello.key_share schema definition (SubRecord misuse) #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dadrian merged 1 commit into from
Feb 18, 2026
Merged

fix: ServerHello.key_share schema definition (SubRecord misuse) #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions zcrypto_schemas/zcrypto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,8 +661,7 @@ def getUnknowns(known, range, unknown="unknown"):
"raw": Binary(),
}), doc="The values in the SignedCertificateTimestampList of the Signed Certificate Timestamp, if present."),
"supported_versions": ServerSupportedVersions(doc="The list of supported versions in the Supported Versions extension, if present (see https://tools.ietf.org/html/draft-ietf-tls-tls13-18#section-4.2.1)."),
"key_share": SubRecord({
CurveID(doc="Negotiated TLS 1.3 key exchange group (NamedGroup/CurveID)."),}),
"key_share": CurveID(doc="Negotiated TLS 1.3 key exchange group (NamedGroup/CurveID)."),
"alpn_protocol": String(doc="This contains the selected protocol from the Application-Layer Protocol Negotiation extension, if present (see https://tools.ietf.org/html/rfc7301)."),
"extension_identifiers": ListOf(Unsigned16BitInteger(), category="Extension Identifiers", doc="The list of unparsed TLS extension identifiers in handshake."),
"unknown_extensions": ListOf(Binary(), doc="A list of any unrecognized extensions in raw form."),
Expand Down
Loading