Draft
Conversation
mvasilak
force-pushed
the
add-custom-pdf-annotation-provider
branch
from
9bf7537 to
fa45c42
Compare
Add custom data for PDF annotation base color Improve PDF annotations reader key retrieval Use extra PDF document annotation colors in filtering Improve PDF annotations filtering Ignore PDF annotation links when filtering Convert PDF reader document annotations to lazy results Compute annotations pages index set in PDF reader action handler Use page sections in PDF annotations view controller Allow read annotations database request for specific page Cache document annotations based on file md5 Make reader side bar load lazy Override class for locked document annotations Improve annotation preview deletion logic Improve code Fix typo
mvasilak
force-pushed
the
add-custom-pdf-annotation-provider
branch
from
fa45c42 to
9ad8eb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds custom PDF document annotation provider, as the first part of PDF reader performance improvements.
In a next part, the database annotations will also be loaded through the custom annotation provider, and they will be loaded per page request, not having to go through all annotations when the document loads, or for every related operation. E.g. filtering will also happen in the provider context, so that only pages used will be modified, if needed. Annotations view controller will also be made more performative and potentially decoupled from PDF reader action handler.