Skip to content

Add custom PDF annotation provider #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mvasilak wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Add custom PDF annotation provider #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83f333a
Improve code
mvasilak Jan 23, 2026
edbf1f7
Add custom PDF document annotation provider
mvasilak Jan 24, 2026
ec6cbb6
Fix annotation preview rendering when moving from dark appearance
mvasilak Feb 10, 2026
7052fcb
Improve deletion of stale document annotations cache logic
mvasilak Feb 10, 2026
9ad8eb5
Improve annotation provider cache load workflow
mvasilak Feb 12, 2026
5a4df9c
Cleanup code
mvasilak Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions Zotero.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
objects = {

/* Begin PBXBuildFile section */
2E2BF2EF2B40911DF4BCEDA4 /* RDocumentAnnotationCacheInfo.swift in Sources */ = {isa = PBXBuildFile; fileRef = 54BFF736AADBBF8C2FEBD348 /* RDocumentAnnotationCacheInfo.swift */; };
34319EFF474800EB6BA60376 /* StoreDocumentAnnotationsCacheDbRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = CB95656CF4AD91246DF78BDA /* StoreDocumentAnnotationsCacheDbRequest.swift */; };
5ECD47C4C5AE63E78DA60C6C /* ReadDocumentAnnotationsCacheDbRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5297BAC833EEE6973ACA9818 /* ReadDocumentAnnotationsCacheDbRequest.swift */; };
6102D2B22D68ABF100505E6A /* bitcoin_pdf_recognizer_data.json in Resources */ = {isa = PBXBuildFile; fileRef = 6102D2B12D68ABD900505E6A /* bitcoin_pdf_recognizer_data.json */; };
6102D2B62D68B5E800505E6A /* bitcoin_pdf_full_text.json in Resources */ = {isa = PBXBuildFile; fileRef = 6102D2B52D68B5DE00505E6A /* bitcoin_pdf_full_text.json */; };
6102D2B82D6CCDD300505E6A /* RemoteRecognizerResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6102D2B72D6CCDD300505E6A /* RemoteRecognizerResponse.swift */; };
Expand Down Expand Up @@ -76,10 +79,15 @@
61E24DCC2ABB385E00D75F50 /* OpenItemsController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 61E24DCB2ABB385E00D75F50 /* OpenItemsController.swift */; };
61E3CD502D9545DF00ACA004 /* CitationWebViewHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = 61E3CD4F2D9545DF00ACA004 /* CitationWebViewHandler.swift */; };
61EB05B42C9D8EA200152482 /* CreateReaderAnnotationsDbRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 61EB05B22C9D8EA200152482 /* CreateReaderAnnotationsDbRequest.swift */; };
61F6B8A22E95D00100A71F01 /* PDFReaderAnnotationProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = 61F6B8A12E95D00100A71F01 /* PDFReaderAnnotationProvider.swift */; };
61FA14CE2B05081D00E7D423 /* TextConverter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 61FA14CD2B05081D00E7D423 /* TextConverter.swift */; };
61FA14D02B08E24A00E7D423 /* ColorPickerStackView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 61FA14CF2B08E24A00E7D423 /* ColorPickerStackView.swift */; };
61FB13D72EECBE0A00329563 /* bitcoin_pdf_page_0_text.json in Sources */ = {isa = PBXBuildFile; fileRef = 61FB13D62EECBE0700329563 /* bitcoin_pdf_page_0_text.json */; };
61FB13D82EED6D6E00329563 /* bitcoin_pdf_page_0_text.json in Resources */ = {isa = PBXBuildFile; fileRef = 61FB13D62EECBE0700329563 /* bitcoin_pdf_page_0_text.json */; };
6322C296BBE6360E74142CBD /* DeleteDocumentAnnotationsCacheDbRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = B9848C1C2FEC525D709F292F /* DeleteDocumentAnnotationsCacheDbRequest.swift */; };
871AB639A5C7E5E9AF08CC1C /* LibraryScoped.swift in Sources */ = {isa = PBXBuildFile; fileRef = 977B760291F3124DBBCC6203 /* LibraryScoped.swift */; };
9379A103B7827A0C9E3DB2CD /* LibraryScoped.swift in Sources */ = {isa = PBXBuildFile; fileRef = 977B760291F3124DBBCC6203 /* LibraryScoped.swift */; };
AB5758C506E90C77CA8CC16A /* ReadAnnotationPagesDbRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = ADB7B93609C1F05696319226 /* ReadAnnotationPagesDbRequest.swift */; };
B300B33324291C8D00C1FE1E /* RTranslatorMetadata.swift in Sources */ = {isa = PBXBuildFile; fileRef = B300B33224291C8D00C1FE1E /* RTranslatorMetadata.swift */; };
B300B3352429222B00C1FE1E /* TranslatorMetadata.swift in Sources */ = {isa = PBXBuildFile; fileRef = B300B3342429222B00C1FE1E /* TranslatorMetadata.swift */; };
B300B3362429234C00C1FE1E /* TranslatorMetadata.swift in Sources */ = {isa = PBXBuildFile; fileRef = B300B3342429222B00C1FE1E /* TranslatorMetadata.swift */; };
Expand Down Expand Up @@ -1282,6 +1290,9 @@
B3FE4B9C268DDE6100CE123F /* CitationBibliographyExportCoordinator.swift in Sources */ = {isa = PBXBuildFile; fileRef = B3FE4B9B268DDE6100CE123F /* CitationBibliographyExportCoordinator.swift */; };
B3FE79E32B332E5E009FBDBD /* CreateEditDownloadDbRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = B30548F52B331B1A00853966 /* CreateEditDownloadDbRequest.swift */; };
B3FE79E42B333030009FBDBD /* DeleteDownloadDbRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = B30548F72B331B2500853966 /* DeleteDownloadDbRequest.swift */; };
C988B9E9211AB3BFE72CFA11 /* RDocumentAnnotationCacheInfo.swift in Sources */ = {isa = PBXBuildFile; fileRef = 54BFF736AADBBF8C2FEBD348 /* RDocumentAnnotationCacheInfo.swift */; };
C9ECF06C37EDB9963713C4A0 /* RDocumentAnnotation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 17E83150004BDA76942E1350 /* RDocumentAnnotation.swift */; };
D1159AE7B0BBC3D7A1954D00 /* RDocumentAnnotation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 17E83150004BDA76942E1350 /* RDocumentAnnotation.swift */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand Down Expand Up @@ -1353,6 +1364,9 @@
/* End PBXCopyFilesBuildPhase section */

/* Begin PBXFileReference section */
17E83150004BDA76942E1350 /* RDocumentAnnotation.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RDocumentAnnotation.swift; sourceTree = "<group>"; };
5297BAC833EEE6973ACA9818 /* ReadDocumentAnnotationsCacheDbRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ReadDocumentAnnotationsCacheDbRequest.swift; sourceTree = "<group>"; };
54BFF736AADBBF8C2FEBD348 /* RDocumentAnnotationCacheInfo.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RDocumentAnnotationCacheInfo.swift; sourceTree = "<group>"; };
6102D2B12D68ABD900505E6A /* bitcoin_pdf_recognizer_data.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = bitcoin_pdf_recognizer_data.json; sourceTree = "<group>"; };
6102D2B52D68B5DE00505E6A /* bitcoin_pdf_full_text.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = bitcoin_pdf_full_text.json; sourceTree = "<group>"; };
6102D2B72D6CCDD300505E6A /* RemoteRecognizerResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RemoteRecognizerResponse.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1393,9 +1407,12 @@
61E24DCB2ABB385E00D75F50 /* OpenItemsController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OpenItemsController.swift; sourceTree = "<group>"; };
61E3CD4F2D9545DF00ACA004 /* CitationWebViewHandler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CitationWebViewHandler.swift; sourceTree = "<group>"; };
61EB05B22C9D8EA200152482 /* CreateReaderAnnotationsDbRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CreateReaderAnnotationsDbRequest.swift; sourceTree = "<group>"; };
61F6B8A12E95D00100A71F01 /* PDFReaderAnnotationProvider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PDFReaderAnnotationProvider.swift; sourceTree = "<group>"; };
61FA14CD2B05081D00E7D423 /* TextConverter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextConverter.swift; sourceTree = "<group>"; };
61FA14CF2B08E24A00E7D423 /* ColorPickerStackView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ColorPickerStackView.swift; sourceTree = "<group>"; };
61FB13D62EECBE0700329563 /* bitcoin_pdf_page_0_text.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = bitcoin_pdf_page_0_text.json; sourceTree = "<group>"; };
977B760291F3124DBBCC6203 /* LibraryScoped.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LibraryScoped.swift; sourceTree = "<group>"; };
ADB7B93609C1F05696319226 /* ReadAnnotationPagesDbRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ReadAnnotationPagesDbRequest.swift; sourceTree = "<group>"; };
B300B33224291C8D00C1FE1E /* RTranslatorMetadata.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RTranslatorMetadata.swift; sourceTree = "<group>"; };
B300B3342429222B00C1FE1E /* TranslatorMetadata.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TranslatorMetadata.swift; sourceTree = "<group>"; };
B300B3372429254900C1FE1E /* SyncTranslatorsDbRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SyncTranslatorsDbRequest.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -2458,6 +2475,8 @@
B3FE4B94268DDE4900CE123F /* CitationBibliographyExportState.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CitationBibliographyExportState.swift; sourceTree = "<group>"; };
B3FE4B96268DDE4900CE123F /* CitationBibliographyExportView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CitationBibliographyExportView.swift; sourceTree = "<group>"; };
B3FE4B9B268DDE6100CE123F /* CitationBibliographyExportCoordinator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CitationBibliographyExportCoordinator.swift; sourceTree = "<group>"; };
B9848C1C2FEC525D709F292F /* DeleteDocumentAnnotationsCacheDbRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DeleteDocumentAnnotationsCacheDbRequest.swift; sourceTree = "<group>"; };
CB95656CF4AD91246DF78BDA /* StoreDocumentAnnotationsCacheDbRequest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StoreDocumentAnnotationsCacheDbRequest.swift; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
Expand Down Expand Up @@ -2691,6 +2710,7 @@
B37ACB922730338A002EF4E1 /* DeleteAllWebDavDeletionsDbRequest.swift */,
B3D06ADD29DD8C21009C0D98 /* DeleteAutomaticTagsDbRequest.swift */,
B3863FC92AD830DE005082F0 /* DeleteCreatorItemDetailDbRequest.swift */,
B9848C1C2FEC525D709F292F /* DeleteDocumentAnnotationsCacheDbRequest.swift */,
B30548F72B331B2500853966 /* DeleteDownloadDbRequest.swift */,
B373B1B62BBD748600DCF893 /* DeleteFailedItemsDbRequest.swift */,
B305644223FC051E003304F2 /* DeleteGroupDbRequest.swift */,
Expand Down Expand Up @@ -2740,6 +2760,7 @@
B305644823FC051E003304F2 /* ReadAllGroupsDbRequest.swift */,
B319D6B5265CE05000E52132 /* ReadAllItemsForUploadDbRequest.swift */,
B34341AA260A48A200093E63 /* ReadAllWritableGroupsDbRequest.swift */,
ADB7B93609C1F05696319226 /* ReadAnnotationPagesDbRequest.swift */,
B31EEE5924EBD18200E3B3AD /* ReadAnnotationsDbRequest.swift */,
B305646523FC051E003304F2 /* ReadAnyChangedObjectsInLibraryDbRequest.swift */,
B305644523FC051E003304F2 /* ReadAttachmentUploadsDbRequest.swift */,
Expand All @@ -2750,7 +2771,9 @@
B305645723FC051E003304F2 /* ReadCollectionsDbRequest.swift */,
B3F55A1A29EED4EA00A6716E /* ReadColoredTagsDbRequest.swift */,
B305644B23FC051E003304F2 /* ReadDeletedObjectsDbRequest.swift */,
5297BAC833EEE6973ACA9818 /* ReadDocumentAnnotationsCacheDbRequest.swift */,
B37BF0B025A6035D00AE0268 /* ReadDocumentDataDbRequest.swift */,
CB95656CF4AD91246DF78BDA /* StoreDocumentAnnotationsCacheDbRequest.swift */,
B3A53FF62B14CDB2004BB9D7 /* ReadEmojiTagsDbRequest.swift */,
B34A9F5D25BF12F7007C9A4A /* ReadFilenameDbRequest.swift */,
B3F55A1629EED04700A6716E /* ReadFilteredTagsDbRequest.swift */,
Expand Down Expand Up @@ -3028,9 +3051,12 @@
isa = PBXGroup;
children = (
B353F202242E52610062EE24 /* Database.swift */,
977B760291F3124DBBCC6203 /* LibraryScoped.swift */,
B305653023FC051E003304F2 /* RCollection.swift */,
B305653123FC051E003304F2 /* RCreator.swift */,
B305653723FC051E003304F2 /* RCustomLibrary.swift */,
17E83150004BDA76942E1350 /* RDocumentAnnotation.swift */,
54BFF736AADBBF8C2FEBD348 /* RDocumentAnnotationCacheInfo.swift */,
B30548F92B331B3D00853966 /* RDownload.swift */,
B305653523FC051E003304F2 /* RGroup.swift */,
B305653223FC051E003304F2 /* RItem.swift */,
Expand Down Expand Up @@ -4121,6 +4147,7 @@
B385B70D25C03E7E0073CA6F /* PDFExportState.swift */,
B3B953C9245981AD00FC96DB /* PDFReaderAction.swift */,
B3D0AC97255C14AB007648F5 /* PDFReaderLayout.swift */,
61F6B8A12E95D00100A71F01 /* PDFReaderAnnotationProvider.swift */,
B3B953C7245981A600FC96DB /* PDFReaderState.swift */,
B35B473B25F11BCD0023B6F4 /* PDFSettings.swift */,
B310280C2B1E16F300E41554 /* PDFThumbnailsAction.swift */,
Expand Down Expand Up @@ -5568,6 +5595,7 @@
B37D8E6924DC2BEE00F526C5 /* CollectionRow.swift in Sources */,
B3593F56241A61C700760E20 /* CollectionCell.swift in Sources */,
B3B953C8245981A600FC96DB /* PDFReaderState.swift in Sources */,
61F6B8A22E95D00100A71F01 /* PDFReaderAnnotationProvider.swift in Sources */,
B3D84BED27917E3D005DDD7C /* UpdateCreatorSummaryFormatDbRequest.swift in Sources */,
B3F3D632255EC5F200F310C2 /* AnnotationViewHighlightContent.swift in Sources */,
B395EFE725494B2300CEBD9F /* CreatorEditState.swift in Sources */,
Expand Down Expand Up @@ -5666,6 +5694,7 @@
B3B953D22459B4D800FC96DB /* UITableViewCell+SwiftUI.swift in Sources */,
612361072D439D6A007FA575 /* PDFWorkerWebViewHandler.swift in Sources */,
B353F204242E52610062EE24 /* Database.swift in Sources */,
9379A103B7827A0C9E3DB2CD /* LibraryScoped.swift in Sources */,
B30565E023FC051E003304F2 /* ReadAnyChangedObjectsInLibraryDbRequest.swift in Sources */,
B30566C023FC051F003304F2 /* DownloadBatch.swift in Sources */,
B305660D23FC051E003304F2 /* AttachmentUploadRequest.swift in Sources */,
Expand Down Expand Up @@ -5693,6 +5722,11 @@
B34A9F6825BF1D27007C9A4A /* AnnotationConverter.swift in Sources */,
B3A081C425D2ADCD0088EC24 /* PerformDeletionsSyncAction.swift in Sources */,
B3DAF84D2AC5AA5C00F9AB6A /* PDFDocumentAnnotation.swift in Sources */,
D1159AE7B0BBC3D7A1954D00 /* RDocumentAnnotation.swift in Sources */,
2E2BF2EF2B40911DF4BCEDA4 /* RDocumentAnnotationCacheInfo.swift in Sources */,
5ECD47C4C5AE63E78DA60C6C /* ReadDocumentAnnotationsCacheDbRequest.swift in Sources */,
34319EFF474800EB6BA60376 /* StoreDocumentAnnotationsCacheDbRequest.swift in Sources */,
6322C296BBE6360E74142CBD /* DeleteDocumentAnnotationsCacheDbRequest.swift in Sources */,
B361C2B429DECB220035BF7E /* ResetSettingsVersionDbRequest.swift in Sources */,
B30565B623FC051E003304F2 /* StoreItemsDbResponseRequest.swift in Sources */,
B37352AF2E140DF10078BB00 /* AccessibilityViewHandler.swift in Sources */,
Expand Down Expand Up @@ -5889,6 +5923,7 @@
B30565DE23FC051E003304F2 /* SyncVersionsDbRequest.swift in Sources */,
B3DCDF06240912060039ED0D /* DocumentPickerViewController.swift in Sources */,
B37BF0B125A6035D00AE0268 /* ReadDocumentDataDbRequest.swift in Sources */,
AB5758C506E90C77CA8CC16A /* ReadAnnotationPagesDbRequest.swift in Sources */,
B300B33324291C8D00C1FE1E /* RTranslatorMetadata.swift in Sources */,
B310FA4529E5765800FA2F15 /* AddTagsToItemDbRequest.swift in Sources */,
B39D42DF29C0CE7D0035CDA9 /* TagsFlowLayout.swift in Sources */,
Expand Down Expand Up @@ -6214,7 +6249,10 @@
B305674323FC09AF003304F2 /* LoginResponse.swift in Sources */,
B305674423FC09AF003304F2 /* DeletionsResponse.swift in Sources */,
B31EEE5824EBCB2C00E3B3AD /* RRect.swift in Sources */,
C9ECF06C37EDB9963713C4A0 /* RDocumentAnnotation.swift in Sources */,
C988B9E9211AB3BFE72CFA11 /* RDocumentAnnotationCacheInfo.swift in Sources */,
B353F207242E52EE0062EE24 /* Database.swift in Sources */,
871AB639A5C7E5E9AF08CC1C /* LibraryScoped.swift in Sources */,
B305674523FC09AF003304F2 /* GroupResponse.swift in Sources */,
B3F0FDCB2888185D00949BC9 /* MarkFileAsDownloadedDbRequest.swift in Sources */,
B305674623FC09AF003304F2 /* SearchesResponse.swift in Sources */,
Expand Down
Loading