changes to address #646 - Adjust highlight comment icon#674
Open
nataliachodelski wants to merge 1 commit intozotero:masterfrom
Open
changes to address #646 - Adjust highlight comment icon#674nataliachodelski wants to merge 1 commit intozotero:masterfrom
nataliachodelski wants to merge 1 commit intozotero:masterfrom
Conversation
- reduced note icon size from 22 to 16 - added 50% opacity to fill color used for comment icons - added 50% opacity to fill color used for note icon that is added highlight
|
@nataliachodelski, I believe issue #646 is more concerned with the size of the highlight comment icon (the yellow one in the screenshots) and not the note annotation icon, although perhaps those should be made consistent with the desktop app as well if they aren't already. |
9a32b1b to
21c3d9c
Compare
I think both the highlight and note icons are too huge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm a research scientist who recently started using Zotero to collaborate with a friend on several reference collections.
I'm also an iOS developer, and have been looking for open source projects to contribute to and came across Zotero. I've spent some time exploring the repository and forum discussions to see if I could address any open, unassigned issues.
I looked into issue #646 and wanted to propose a few small changes to improve to the size and opacity of the note annotations shown on PDFs, re the discussion on this post: https://forums.zotero.org/discussion/comment/424317.
I made the following changes:
Sample screenshots of note and highlight annotations with my these changes

Sample screenshots of the same PDF before these changes (in the current App Store app)
