Skip to content

changes to address #646 - Adjust highlight comment icon#674

Open
nataliachodelski wants to merge 1 commit intozotero:masterfrom
nataliachodelski:adjustPDFCommentIcons-#646
Open

changes to address #646 - Adjust highlight comment icon#674
nataliachodelski wants to merge 1 commit intozotero:masterfrom
nataliachodelski:adjustPDFCommentIcons-#646

Conversation

@nataliachodelski
Copy link

Hi, I'm a research scientist who recently started using Zotero to collaborate with a friend on several reference collections.
I'm also an iOS developer, and have been looking for open source projects to contribute to and came across Zotero. I've spent some time exploring the repository and forum discussions to see if I could address any open, unassigned issues.

I looked into issue #646 and wanted to propose a few small changes to improve to the size and opacity of the note annotations shown on PDFs, re the discussion on this post: https://forums.zotero.org/discussion/comment/424317.

I made the following changes:

  • reduced note icon size from 22 to 16 (initially tried 12, but the icons looked too small when I tested it)
  • added 50% opacity to fill color used for comment icons
  • added 50% opacity to fill color used for note icon that is added highlight

Sample screenshots of note and highlight annotations with my these changes


Sample screenshots of the same PDF before these changes (in the current App Store app)

- reduced note icon size from 22 to 16
- added 50% opacity to fill color used for comment icons
- added 50% opacity to fill color used for note icon that is added highlight
@warwickmm
Copy link

warwickmm commented Apr 28, 2023

@nataliachodelski, I believe issue #646 is more concerned with the size of the highlight comment icon (the yellow one in the screenshots) and not the note annotation icon, although perhaps those should be made consistent with the desktop app as well if they aren't already.

@michalrentka michalrentka force-pushed the master branch 2 times, most recently from 9a32b1b to 21c3d9c Compare June 1, 2023 14:13
@mathjiajia
Copy link

@nataliachodelski, I believe issue #646 is more concerned with the size of the highlight comment icon (the yellow one in the screenshots) and not the note annotation icon, although perhaps those should be made consistent with the desktop app as well if they aren't already.

I think both the highlight and note icons are too huge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants