Skip to content

changes to address #646 - Adjust highlight comment icon #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nataliachodelski wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changes to address #646 - Adjust highlight comment icon #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zotero/Controllers/CommentIconDrawingController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ struct CommentIconDrawingController {
let newBoundingBox = CGRect(origin: origin, size: size)

context.clip(to: newBoundingBox, mask: colorizedCgImage)
color.setFill()
color.withAlphaComponent(0.5).setFill()
context.fill(newBoundingBox)

context.resetClip()
Expand Down
2 changes: 1 addition & 1 deletion Zotero/Models/AnnotationsConfig.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct AnnotationsConfig {
// Line width of image annotation in PDF document.
static let imageAnnotationLineWidth: CGFloat = 2
// Size of note annotation in PDF document.
static let noteAnnotationSize: CGSize = CGSize(width: 22, height: 22)
static let noteAnnotationSize: CGSize = CGSize(width: 16, height: 16)
static let positionSizeLimit = 65000
static let supported: PSPDFKit.Annotation.Kind = [.note, .highlight, .square, .ink]

Expand Down
2 changes: 1 addition & 1 deletion Zotero/Scenes/Detail/PDF/Models/NoteAnnotation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ final class NoteAnnotation: PSPDFKit.NoteAnnotation {
guard let colorizedCgImage = colorizedImage.cgImage, let outlineCgImage = outlineImage.cgImage, let color = self.color else { return }

context.clip(to: boundingBox, mask: colorizedCgImage)
color.setFill()
color.withAlphaComponent(0.5).setFill()
context.fill(boundingBox)

context.resetClip()
Expand Down