feat(desktop-sidebar): update sidebar buttons to match web app design#1470
Open
Lucky-Sharma wants to merge 2 commits intozulip:mainfrom
Open
feat(desktop-sidebar): update sidebar buttons to match web app design#1470Lucky-Sharma wants to merge 2 commits intozulip:mainfrom
Lucky-Sharma wants to merge 2 commits intozulip:mainfrom
Conversation
Lucky-Sharma
force-pushed
the
Update-icons-app-sidebar
branch
from
3e2d9cc to
011efab
Compare
Lucky-Sharma
force-pushed
the
Update-icons-app-sidebar
branch
from
011efab to
833ddaf
Compare
Member
|
Please checkout https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html and modify your commits. Please check the issue description and make sure your solution follows the issue spec completely. Reload and back are not using the icons suggested in the issue description. My suggestion for you is to get feedback on whether everything looks as expected is to post your screenshots in #design > desktop app buttons #D1436 @ 💬 and modify your PR once all the feedback is addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1436.
This PR updates the Zulip Desktop sidebar to match the web app design by reordering action buttons (Back → Reload → Loading → Do Not Disturb → Settings) and fixing the Do Not Disturb tooltip truncation to display full text and back button icone.
Screenshots posted in: #https://chat.zulip.org/#narrow/channel/101-design/topic/desktop.20app.20buttons.20.23D1436/near/2205662
**Platforms this PR was tested on: