Skip to content

Minor: Fix f-strings in Quadplane SimBatteryResistance test #33770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hunt0r wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −6
Open

Minor: Fix f-strings in Quadplane SimBatteryResistance test #33770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions Tools/autotest/quadplane.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2499,28 +2499,29 @@ def hover_voltage():
# with sag disabled the pack should read close to its resting voltage
self.set_parameter("SIM_BATT_RES_OHM", 0)
v_no_sag = hover_voltage()
self.progress(f"hover voltage, sag disabled: {v_no_sag}V")
self.progress(f"hover voltage, sag disabled: {v_no_sag:.4f}V")
if abs(v_no_sag - 12.6) > 0.2:
raise NotAchievedException(
"Expected ~resting voltage with sag disabled, got {v_no_sag}V")
f"Expected ~resting voltage with sag disabled, got {v_no_sag:.4f}V")

# introducing resistance should sag the voltage under the same load
hover_voltage_ohms = 0.05
self.set_parameter("SIM_BATT_RES_OHM", hover_voltage_ohms)
v_sag = hover_voltage()
self.progress("hover voltage, {hover_voltage_ohms}ohm: {v_sag}V")
self.progress(f"hover voltage, {hover_voltage_ohms:.4f}ohm: {v_sag:.4f}V")
if v_sag > v_no_sag - 0.3:
raise NotAchievedException(
"Expected voltage sag with resistance, got {v_sag}V (no-sag {v_no_sag}V)")
f"Expected voltage sag with resistance, got {v_sag:.4f}V (no-sag {v_no_sag:.4f}V)")

# more resistance should sag the voltage further still
hover_voltage_more_ohms = 0.1
self.set_parameter("SIM_BATT_RES_OHM", hover_voltage_more_ohms)
v_more_sag = hover_voltage()
self.progress("hover voltage, {hover_voltage_more_ohms}ohm: {v_more_sag}V")
self.progress(f"hover voltage, {hover_voltage_more_ohms:.4f}ohm: {v_more_sag:.4f}V")
if v_more_sag > v_sag - 0.2:
raise NotAchievedException(
"Expected more sag at higher resistance, got {v_more_sag}V ({hover_voltage_more_ohms}ohm {v_sag}V)")
f"Expected more sag at higher resistance, got {v_more_sag:.4f}V"
f" ({hover_voltage_more_ohms:.4f}ohm {v_sag:.4f}V)")

# restore full thrust before landing so the RTL is not handicapped
self.set_parameter("SIM_BATT_RES_OHM", 0)
Expand Down
Loading