Refactor structure of launch files reduce duplication when adding new simulations#28
Refactor structure of launch files reduce duplication when adding new simulations#28
Conversation
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
…persistance Signed-off-by: Gerardo Puga <glpuga@gmail.com>
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
Signed-off-by: Gerardo Puga <glpuga@gmail.com>
0745a16 to
bc5448c
Compare
| @@ -0,0 +1,29 @@ | |||
| BSD 3-Clause License | |||
There was a problem hiding this comment.
What advantage do we have in having ar4_gazebo_sim and ar4_gazebo_bringup as separate packages instead of just one ar4_gazebo?
There was a problem hiding this comment.
Arguably, it would be totally possible have just one, so you can say this is mostly personal preference.
However, out of experience I find that keeping them separate allows to have a launch file that will only launch the simulation (or hardware) parts without the common parts, which comes handy when debugging the hardware/simulation layer.
Bringup packages end up being only a front-end for the packages needed for any particular configuration, and in the case of simulation, it's the single fail-safe place to set the use_sim_time param for the whole set without risking omissions.
Regarding naming, packages starting a robot (or a simulation of one) must end in "bringup" to give a hint to the user of their function.
Indeed, I know. And potentially a Mujoco simulation coming (either by someone, or a test one I might try later today), but I think there's advantage both in reuse and clarity in the structure proposed here, and it'll get harder to refactor later. Regarding the isaac_sim branch, looking at the changes, there should be no conflict with this branch in the robot description because I only added a single file in there, and changed no other. The ar4_isaac package does not depend on anything I changed, so it can be merged with no conflict. We might have small conflicts on the README file and in the docker-compose file, though. We can keep this PR on hold until we merge the isaac_sim branch, then I'll rebase this, fix conflicts and refactor the isaac_sim package in the same structure as this in this same PR. We can then test also the hardware launch files before finally merging. Thanks for the review. |
|
Closing as this will be replaced with #29 |
The gazebo simulation is now launched with:
graph TD A[**ar4_moveit_config** <br> main.launch.py] B[**ar4_common** <br> main.launch.py] C[**ar4_description** <br> main.launch.py] D[**ar4_gazebo_sim** <br> main.launch.py] E[**ar4_gazebo_bringup** <br> main.launch.py] F[**ar4_hardware_interface** <br> main.launch.py] G[**ar4_realbot_bringup** <br> main.launch.py] A --> F C --> F H[**ar4_isaac_bringup** <br> main.launch.py <br> ...not yet available...] I[**...** <br> main.launch.py] B --> H I --> H J[**ar4_mujoco_bringup** <br> main.launch.py <br> ...not yet available...] K[**...** <br> main.launch.py] B --> J K --> J A --> B C --> D C --> A B --> E D --> E B --> G F --> G