chore(deps-dev): bump the tooling group across 1 directory with 3 updates#53
Merged
Merged
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/tooling-af38d642f5
branch
from
bfa6d03 to
89700ac
Compare
…ates Bumps the tooling group with 3 updates in the / directory: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node), [turbo](https://github.com/vercel/turborepo) and [typescript](https://github.com/microsoft/TypeScript). Updates `@types/node` from 22.19.17 to 25.7.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `turbo` from 2.9.6 to 2.9.12 - [Release notes](https://github.com/vercel/turborepo/releases) - [Changelog](https://github.com/vercel/turborepo/blob/main/RELEASE.md) - [Commits](vercel/turborepo@v2.9.6...v2.9.12) Updates `typescript` from 5.9.3 to 6.0.3 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v6.0.3) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 25.6.2 dependency-type: direct:development update-type: version-update:semver-major dependency-group: tooling - dependency-name: turbo dependency-version: 2.9.12 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: tooling - dependency-name: typescript dependency-version: 6.0.3 dependency-type: direct:development update-type: version-update:semver-major dependency-group: tooling ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/tooling-af38d642f5
branch
from
89700ac to
861b8f3
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request updates development dependencies across the monorepo. The root package.json bumps Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 17-23: The package declares a Node runtime floor in the
"engines"."node" field that conflicts with the TypeScript typings version in the
"devDependencies" ("@types/node"); update one of them so they match: either
change the "@types/node" version in devDependencies to "^22.0.0" (or a 22.x
range) to reflect "engines.node": ">=22.0.0", or raise "engines"."node" to
">=25.0.0" if you want to keep "@types/node" at "^25.7.0"; ensure you update the
corresponding package.json field ("@types/node" or "engines.node") accordingly
and run install/type-check to verify compatibility.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 85e4f113-caef-4452-89e4-d308ba32d966
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
apps/api/package.jsonapps/indexer/package.jsonpackage.jsonpackages/chain/package.jsonpackages/db/package.json
Comment on lines
+17
to
23
| "@types/node": "^25.7.0", | ||
| "prettier": "^3.4.2", | ||
| "turbo": "^2.3.3", | ||
| "typescript": "^5.7.2" | ||
| "turbo": "^2.9.12", | ||
| "typescript": "^6.0.3" | ||
| }, | ||
| "engines": { | ||
| "node": ">=22.0.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only verification: compare Node engine declarations vs `@types/node` majors.
# Expected: `@types/node` major should not exceed the intended runtime major floor.
python - <<'PY'
import json, re, subprocess, pathlib
files = subprocess.check_output(["fd", "-HI", "^package\\.json$"]).decode().splitlines()
engine_re = re.compile(r'>=\s*(\d+)')
types_re = re.compile(r'^\^?(\d+)')
for f in sorted(files):
p = pathlib.Path(f)
try:
data = json.loads(p.read_text())
except Exception:
continue
node_engine = ((data.get("engines") or {}).get("node"))
types_node = ((data.get("devDependencies") or {}).get("@types/node"))
eng_major = None
typ_major = None
if isinstance(node_engine, str):
m = engine_re.search(node_engine)
if m:
eng_major = int(m.group(1))
if isinstance(types_node, str):
m = types_re.match(types_node.strip())
if m:
typ_major = int(m.group(1))
if node_engine or types_node:
print(f"{f}: engines.node={node_engine!r}, `@types/node`={types_node!r}")
if eng_major is not None and typ_major is not None and typ_major > eng_major:
print(f" -> potential mismatch: typings major {typ_major} > runtime floor {eng_major}")
PYRepository: Sentriscloud/indexer
Length of output: 455
Align Node typings with the declared runtime floor.
At Line 17, @types/node is ^25.7.0 while Line 23 declares runtime Node >=22.0.0. This mismatch allows type-checking of APIs unavailable on Node 22, creating runtime safety risks. Either pin @types/node to ^22.0.0 or raise the minimum Node runtime to ^25.0.0.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` around lines 17 - 23, The package declares a Node runtime floor
in the "engines"."node" field that conflicts with the TypeScript typings version
in the "devDependencies" ("@types/node"); update one of them so they match:
either change the "@types/node" version in devDependencies to "^22.0.0" (or a
22.x range) to reflect "engines.node": ">=22.0.0", or raise "engines"."node" to
">=25.0.0" if you want to keep "@types/node" at "^25.7.0"; ensure you update the
corresponding package.json field ("@types/node" or "engines.node") accordingly
and run install/type-check to verify compatibility.
@types/node 25 + typescript 6 stopped auto-loading the node ambient types via the default `types` resolution; explicit `types: ['node']` restores access to `node:url`, `node:path`, `process`, `console` in src/migrate.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the tooling group with 3 updates in the / directory: @types/node, turbo and typescript.
Updates
@types/nodefrom 22.19.17 to 25.7.0Commits
Updates
turbofrom 2.9.6 to 2.9.12Release notes
Sourced from turbo's releases.
... (truncated)
Commits
b3f2345publish 2.9.12 to registry2c850cbfix: Allow transit nodes in LSP diagnostics (#12773)1444cc3release(turborepo): 2.9.11 (#12771)a968db7fix: Allow TURBO_EXTENDS in LSP diagnostics (#12770)87d468brelease(turborepo): 2.9.11-canary.7 (#12768)5a4310drelease(turborepo): 2.9.11-canary.6 (#12766)e7c4575fix: Support shimmed VS Code LSP probes (#12767)2db74b4fix: Publish VS Code extension from release tag (#12765)bfffbaarelease(turborepo): 2.9.11-canary.5 (#12764)8a0bd8bci: Stop VS Code publish from blocking release PR (#12763)Updates
typescriptfrom 5.9.3 to 6.0.3Release notes
Sourced from typescript's releases.
Commits
050880cBump version to 6.0.3 and LKGeeae9dd🤖 Pick PR #63401 (Also check package name validity in...) into release-6.0 (#...ad1c695🤖 Pick PR #63368 (Harden ATA package name filtering) into release-6.0 (#63372)0725fb4🤖 Pick PR #63310 (Mark class property initializers as...) into release-6.0 (#...607a22aBump version to 6.0.2 and LKG9e72ab7🤖 Pick PR #63239 (Fix missing lib files in reused pro...) into release-6.0 (#...35ff23d🤖 Pick PR #63163 (Port anyFunctionType subtype fix an...) into release-6.0 (#...e175b69Bump version to 6.0.1-rc and LKGaf4caacUpdate LKG8efd7e8Merge remote-tracking branch 'origin/main' into release-6.0Summary by CodeRabbit