Skip to content

chore(deps-dev): bump the tooling group across 1 directory with 3 updates #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satyakwok merged 2 commits into from
May 12, 2026
Merged

chore(deps-dev): bump the tooling group across 1 directory with 3 updates #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
861b8f3
chore(deps-dev): bump the tooling group across 1 directory with 3 upd…
dependabot[bot] May 12, 2026
3b7b5c9
fix: pin types: ['node'] in packages/db tsconfig
satyakwok May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"viem": "^2.48.11"
},
"devDependencies": {
"@types/node": "^22.10.0",
"@types/node": "^25.7.0",
"tsx": "^4.19.0",
"typescript": "^5.7.2"
"typescript": "^6.0.3"
}
}
4 changes: 2 additions & 2 deletions apps/indexer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
"drizzle-orm": "^0.45.2"
},
"devDependencies": {
"@types/node": "^22.10.0",
"@types/node": "^25.7.0",
"tsx": "^4.19.0",
"typescript": "^5.7.2"
"typescript": "^6.0.3"
}
}
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
"format": "prettier --write \"**/*.{ts,tsx,md,json}\""
},
"devDependencies": {
"@types/node": "^22.10.0",
"@types/node": "^25.7.0",
"prettier": "^3.4.2",
"turbo": "^2.3.3",
"typescript": "^5.7.2"
"turbo": "^2.9.12",
"typescript": "^6.0.3"
},
"engines": {
"node": ">=22.0.0",
Comment on lines +17 to 23
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read-only verification: compare Node engine declarations vs `@types/node` majors.
# Expected: `@types/node` major should not exceed the intended runtime major floor.

python - <<'PY'
import json, re, subprocess, pathlib

files = subprocess.check_output(["fd", "-HI", "^package\\.json$"]).decode().splitlines()
engine_re = re.compile(r'>=\s*(\d+)')
types_re = re.compile(r'^\^?(\d+)')

for f in sorted(files):
    p = pathlib.Path(f)
    try:
        data = json.loads(p.read_text())
    except Exception:
        continue

    node_engine = ((data.get("engines") or {}).get("node"))
    types_node = ((data.get("devDependencies") or {}).get("@types/node"))

    eng_major = None
    typ_major = None

    if isinstance(node_engine, str):
        m = engine_re.search(node_engine)
        if m:
            eng_major = int(m.group(1))

    if isinstance(types_node, str):
        m = types_re.match(types_node.strip())
        if m:
            typ_major = int(m.group(1))

    if node_engine or types_node:
        print(f"{f}: engines.node={node_engine!r}, `@types/node`={types_node!r}")
        if eng_major is not None and typ_major is not None and typ_major > eng_major:
            print(f"  -> potential mismatch: typings major {typ_major} > runtime floor {eng_major}")
PY

Repository: Sentriscloud/indexer

Length of output: 455

Align Node typings with the declared runtime floor.

At Line 17, @types/node is ^25.7.0 while Line 23 declares runtime Node >=22.0.0. This mismatch allows type-checking of APIs unavailable on Node 22, creating runtime safety risks. Either pin @types/node to ^22.0.0 or raise the minimum Node runtime to ^25.0.0.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` around lines 17 - 23, The package declares a Node runtime floor
in the "engines"."node" field that conflicts with the TypeScript typings version
in the "devDependencies" ("@types/node"); update one of them so they match:
either change the "@types/node" version in devDependencies to "^22.0.0" (or a
22.x range) to reflect "engines.node": ">=22.0.0", or raise "engines"."node" to
">=25.0.0" if you want to keep "@types/node" at "^25.7.0"; ensure you update the
corresponding package.json field ("@types/node" or "engines.node") accordingly
and run install/type-check to verify compatibility.

Expand Down
4 changes: 2 additions & 2 deletions packages/chain/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@grpc/proto-loader": "^0.8.1"
},
"devDependencies": {
"@types/node": "^22.10.0",
"typescript": "^5.7.2"
"@types/node": "^25.7.0",
"typescript": "^6.0.3"
}
}
4 changes: 2 additions & 2 deletions packages/db/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"postgres": "^3.4.5"
},
"devDependencies": {
"@types/node": "^22.10.0",
"@types/node": "^25.7.0",
"drizzle-kit": "^0.31.10",
"tsx": "^4.19.0",
"typescript": "^5.7.2"
"typescript": "^6.0.3"
}
}
9 changes: 7 additions & 2 deletions packages/db/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"outDir": "dist",
"rootDir": "src"
"rootDir": "src",
"types": [
"node"
]
},
"include": ["src/**/*"]
"include": [
"src/**/*"
]
}
144 changes: 72 additions & 72 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading