fix: made divider visible in google login form #221

[roseteho]

Closes #221

Summary by CodeRabbit

• Style

  • Updated decorative line color in the login interface for improved visual contrast.

• Bug Fixes

  • Question rows now show dynamic descriptions from item data for accurate content.
  • Fixed localization content: updated prompt text and corrected a malformed translation key that could affect form labeling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Three files modified: a styling tweak in the Google login component's pseudo-element color, a data binding change in the questions container where description now uses item.text, and a translation JSON where generalInfo.title value was updated and experience.textFieldLabel was accidentally renamed/malformed to experience.textFieldLab el.

Changes

Cohort / File(s)	Summary
Styling Updates src/containers/guest-home-page/google-login/GoogleLogin.styles.js	Pseudo-element background color changed from primary.100 to primary.400 for the decorative line.
Data Binding Changes src/containers/my-resources/questions-container/QuestionsContainer.constants.tsx	Question row description prop now uses dynamic item.text instead of a static string.
Localization / JSON Changes src/constants/translations/en/become-tutor.json	generalInfo.title value updated; experience.textFieldLabel key was renamed/malformed to experience.textFieldLab el, introducing an invalid/broken key.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title focuses on making a divider visible in the Google login form, but the changeset includes unrelated modifications to question descriptions and translation files.	The title should reflect all significant changes, or the scope should be narrowed. Consider: 'fix: make divider visible in google login form and update question descriptions' or separate into multiple focused PRs.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Fix all issues with AI Agents 🤖

In @src/constants/translations/en/become-tutor.json:
- Line 9: The JSON key "textFieldLab el" is malformed (contains an embedded
space) and should be renamed to the correct property name used by the code
(e.g., change "textFieldLab el" to "textFieldLabel") so that accesses like
experience.textFieldLabel resolve; update the key in the translations object and
any tests/consumers that reference the incorrect key to use the corrected
"textFieldLabel".

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 396a5c6 and dfec9e7.

📒 Files selected for processing (1)

• src/constants/translations/en/become-tutor.json

🔇 Additional comments (1)

src/constants/translations/en/become-tutor.json (1)

3-3: Change appears unrelated to PR objectives.

The PR states it fixes the Google login form divider visibility (issue #221), but this change updates text in the "become-tutor" registration form. While the text itself is fine, it's unclear why this unrelated change is included in this PR.

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Critical: Malformed JSON key with embedded space.

The key "textFieldLab el" contains a space, breaking standard property access. Code expecting experience.textFieldLabel will fail at runtime.

🔎 Fix for the malformed key

-    "textFieldLab el": "Text here"
+    "textFieldLabel": "Text here"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	"textFieldLab el": "Text here"
	"textFieldLabel": "Text here"

🤖 Prompt for AI Agents

In @src/constants/translations/en/become-tutor.json around line 9, The JSON key
"textFieldLab el" is malformed (contains an embedded space) and should be
renamed to the correct property name used by the code (e.g., change
"textFieldLab el" to "textFieldLabel") so that accesses like
experience.textFieldLabel resolve; update the key in the translations object and
any tests/consumers that reference the incorrect key to use the corrected
"textFieldLabel".