Skip to content

fix: made divider visible in google login form #221 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roseteho wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: made divider visible in google login form #221 #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a416e7
Fix description in questions table #240
roseteho Dec 21, 2025
396a5c6
fix: change divider color in google login #221
roseteho Jan 5, 2026
dfec9e7
fix: update general info description text #238
roseteho Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/constants/translations/en/become-tutor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"generalInfo": {
"title": "Amet minim mollit non deserunt ullamco est sit aliqua dolor do amet sint.",
"title": "Please complete the registration form for the best possible experience.",
"textFieldLabel": "Describe in short your professional status",
"helperText": "Inputs with the * sign are required"
},
"experience": {
"title": "Describe your professional experience. Maximum 70 characters.",
"textFieldLabel": "Text here"
"textFieldLab el": "Text here"

@coderabbitai coderabbitai Bot Jan 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Malformed JSON key with embedded space.

The key "textFieldLab el" contains a space, breaking standard property access. Code expecting experience.textFieldLabel will fail at runtime.

🔎 Fix for the malformed key 
-    "textFieldLab el": "Text here"
+    "textFieldLabel": "Text here"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"textFieldLab el": "Text here"
"textFieldLabel": "Text here"
🤖 Prompt for AI Agents 
In @src/constants/translations/en/become-tutor.json around line 9, The JSON key
"textFieldLab el" is malformed (contains an embedded space) and should be
renamed to the correct property name used by the code (e.g., change
"textFieldLab el" to "textFieldLabel") so that accesses like
experience.textFieldLabel resolve; update the key in the translations object and
any tests/consumers that reference the incorrect key to use the corrected
"textFieldLabel".

},
"languages": {
"title": "Velit officia consequat duis enim velit mollit. Other categories you can add in your account settings later.",
Expand Down
2 changes: 1 addition & 1 deletion src/containers/guest-home-page/google-login/GoogleLogin.styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const styles = {
content: '""',
width: '100%',
height: '2px',
backgroundColor: 'primary.100'
backgroundColor: 'primary.400'
}
},
continue: {
Expand Down
2 changes: 1 addition & 1 deletion src/containers/my-resources/questions-container/QuestionsContainer.constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const columns: TableColumn<Question>[] = [
return (
<Box onClick={handleClick} sx={styles.questionContainer}>
<IconTitleDescription
description={'Which word is the antonym of "benevolent"?'}
description={item.text}
icon={<Box sx={styles.iconWrapper}>{CheckIcons(item.type)}</Box>}
sx={styles.iconTitleDescription}
title={item.title}
Expand Down
Loading