fix: refresh DCR provider client on replace#345
Merged
Conversation
Refactor existing_provider_client check and input_fields assignment.
beubax
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes DCR provider replacement from the UI by clearing the existing dynamically registered client when a DCR provider is replaced without manual client credentials. The UI now handles DCR replacements with no input fields immediately, instead of redirecting to an empty input form.
Motivation and Context
For DCR OAuth providers like Notion DCR, clicking Replace did not actually replace the stored client because there are no manual
client_id/client_secretfields to submit. The existing provider client was preserved, so no change was detected and the old dynamic client kept being reused.With this change, Replace revokes existing connections and clears the saved DCR client so the next login performs dynamic client registration again.
How Has This Been Tested?
uv run pytestuv run ruff check src/ tests/uv run ty check src/uv run pre-commit run --all-filesTypes of changes
Checklist: