Skip to content

fix: refresh DCR provider client on replace #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beubax merged 3 commits into from
May 28, 2026
Merged

fix: refresh DCR provider client on replace #345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
595de28
fix: refresh DCR provider client on replace
ankitranjan7 May 27, 2026
475bdeb
refactor: trigger login flow directly when existing DCR PKCE provider…
ankitranjan7 May 27, 2026
6c108cb
revert: display input fields for dcr providers
beubax May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/authsome/server/credential_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,10 +365,15 @@ async def update_provider_configuration(
return False

existing = await self._get_provider_client_credentials(provider)
refresh_dcr_client = definition.flow == FlowType.DCR_PKCE and existing is not None and "client_id" not in inputs
updated = ProviderClientRecord(provider=provider)
updated.client_id = inputs.get("client_id", existing.client_id if existing else None) or None
updated.client_id = (
None if refresh_dcr_client else inputs.get("client_id", existing.client_id if existing else None) or None
)

if "client_secret" in inputs:
if refresh_dcr_client:
updated.client_secret = None
elif "client_secret" in inputs:
secret_input = inputs["client_secret"].strip()
if secret_input:
updated.client_secret = secret_input
Expand Down
Loading