fix(ng-dev): prevent arbitrary file write via symlink#3734
Open
josephperrott wants to merge 2 commits into
Open
fix(ng-dev): prevent arbitrary file write via symlink#3734josephperrott wants to merge 2 commits into
josephperrott wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a security check to prevent symbolic links in user input by adding a genrule in index.bzl and removing the -L flag from the copy command in optimize.sh. A critical security issue was identified in the genrule where relative symlinks are resolved incorrectly relative to the execroot instead of the symlink's directory, potentially bypassing the check. A code suggestion has been provided to resolve this path resolution issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a vulnerability where arbitrary file writes/information leaks could occur via symlink dereferencing when copying user-controlled files into the optimization build output.
Changes:
-L(dereference) flag fromcp -Rfinoptimize.shto prevent copying symlink targets.genruleinindex.bzlthat acts as a strict security gatekeeper. It validates the original workspacesrcsand securely aborts the build if any of the underlying source files is a symlink, fulfilling strict architectural security requirements while maintaining compatibility with Bazel's internal sandbox symlinking.