Skip to content

fix(ng-dev): prevent arbitrary file write via symlink #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Jun 5, 2026
+26 −1
Merged

fix(ng-dev): prevent arbitrary file write via symlink #3734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3780203
fix(ng-dev): prevent arbitrary file write via symlink
josephperrott Jun 4, 2026
2963ebb
fix(ng-dev): properly handle relative symlinks in security check
josephperrott Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions bazel/rules/rules_angular/src/optimization/index.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,36 @@ def optimize_angular_app(
root_paths = [""],
)

native.genrule(
name = "_%s_check_symlinks" % name,
srcs = srcs,
outs = ["_%s_check_symlinks_passed.txt" % name],
cmd = """
for f in $(SRCS) ""; do
if [ -z "$$f" ]; then continue; fi
target=$$(readlink "$$f" || true)
if [ -n "$$target" ]; then
case "$$target" in
/*) ;;
*) target="$$(dirname "$$f")/$$target" ;;
esac
if [ -h "$$target" ]; then
echo "Security violation: Symbolic links are not permitted in user input. ($$f)" >&2
exit 1
fi
fi
done
touch $@
""",
Comment thread
josephperrott marked this conversation as resolved.
tags = ["manual"],
)

run_binary(
name = "_%s_build" % name,
tool = "@rules_angular//src/optimization:optimize",
tags = ["manual"],
srcs = [
":_%s_check_symlinks" % name,
":_%s_package" % name,
"@yq_toolchains//:resolved_toolchain",
"@rules_angular//src/optimization/boilerplate",
Expand Down
2 changes: 1 addition & 1 deletion bazel/rules/rules_angular/src/optimization/optimize.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ NG_CLI_TOOL="$RUNFILES/$NG_CLI_TOOL_RUNFILES_PATH"
cp -Rf -L $BOILERPLATE_DIR/* $OUT_DIR

# Copy user files.
cp -Rf -L $INPUT_PACKAGE/* $OUT_DIR/src/
cp -Rf $INPUT_PACKAGE/* $OUT_DIR/src/

# Prepare for `angular.json` to be modified below.
unlink $OUT_DIR/angular.json
Expand Down
Loading