tools: avoid returning from finally blocks#19314
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
xiaoxiang781216
approved these changes
Jul 6, 2026
github-actions
Bot
added
Area: CI
Size: XS
|
Old-Ding
force-pushed
the
codex/python-return-finally-warnings
branch
from
f3f25cc to
4bc62ce
Compare
xiaoxiang781216
approved these changes
Jul 8, 2026
Python warns about return statements inside finally blocks because they can suppress pending exceptions. Move the returns after the try/finally and try/except bodies so normal return values stay the same while unexpected exceptions are no longer swallowed. Signed-off-by: Old-Ding <ai.neo.ae86@gmail.com>
Old-Ding
force-pushed
the
codex/python-return-finally-warnings
branch
from
4bc62ce to
a9e6460
Compare
xiaoxiang781216
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing