Skip to content

tools: avoid returning from finally blocks #19314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Old-Ding wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

tools: avoid returning from finally blocks #19314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/ci/testrun/utils/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,8 @@ def sendCommand(self, cmd, *argc, **argv):

if self.method != "minicom":
time.sleep(0.5)
return ret

return ret

def switch_to_original_core(self):
if self.target == "target":
Expand Down
3 changes: 1 addition & 2 deletions tools/pynuttx/nxgdb/net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,7 @@ def check_iob(self):
result = max(result, NetCheckResult.FAILED)
message.append("[FAILED] Failed to check IOB: %s" % e)

finally:
return result, message
return result, message

def invoke(self, args, from_tty):
if utils.get_symbol_value("CONFIG_MM_IOB"):
Expand Down
Loading