Skip to content

build(deps): bump encoding-sniffer from 0.2.1 to 1.0.2#5157

Open
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/encoding-sniffer-1.0.2
Open

build(deps): bump encoding-sniffer from 0.2.1 to 1.0.2#5157
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/encoding-sniffer-1.0.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 18, 2026

Bumps encoding-sniffer from 0.2.1 to 1.0.2.

Release notes

Sourced from encoding-sniffer's releases.

v1.0.2

Include source files for source maps.

v1.0.0

What's Changed

Full Changelog: fb55/encoding-sniffer@v0.2.1...v1.0.0

Commits
  • 47f6a45 1.0.2
  • a3d10f0 1.0.1
  • 77fcd2b fix: include source files for source maps
  • 0cefc9d docs(README): Add security contact information
  • f4decfb 1.0.0
  • a6bcfd6 BREAKING: Make module ESM only (#1211)
  • 486fbf0 build(deps-dev): bump typescript-eslint from 8.57.0 to 8.57.1 (#1265)
  • 185940d build(deps-dev): bump @​biomejs/biome from 2.4.6 to 2.4.7 (#1264)
  • 8e9a391 build(deps-dev): bump @​feedic/eslint-config from 0.2.3 to 0.3.1 (#1263)
  • bc963f9 build(deps-dev): bump @​vitest/coverage-v8 from 4.0.18 to 4.1.0 (#1262)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for encoding-sniffer since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 18, 2026
Bumps [encoding-sniffer](https://github.com/fb55/encoding-sniffer) from 0.2.1 to 1.0.2.
- [Release notes](https://github.com/fb55/encoding-sniffer/releases)
- [Commits](fb55/encoding-sniffer@v0.2.1...v1.0.2)

---
updated-dependencies:
- dependency-name: encoding-sniffer
  dependency-version: 1.0.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/encoding-sniffer-1.0.2 branch from 9978389 to f8efb58 Compare March 20, 2026 00:03
@ChALkeR
Copy link
Copy Markdown

ChALkeR commented Mar 24, 2026

../dist/commonjs/index.d.ts:10:37 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("encoding-sniffer")' call instead.

This is not true on any modern / maintained Node.js version

All maintained Node.js branches can require(ESM)

(except for configs broken by AWS Lambda, but those are documented there & have a config fix)

It does, however, require "node": "^20.19.0 || ^22.12.0 || >=24.0.0" while this repo specifies "node": ">=20.18.1"

@ChALkeR
Copy link
Copy Markdown

ChALkeR commented Mar 26, 2026

Also, as a rule of thumb, it's usually good to place the minimal actually supported Node.js version into the CI matrix

Currently, Cheerio has this:

matrix:
node:
- 20
- 22
- 24
- lts/*

Which tests only latest versions in those branches
I.e. only versions with require(ESM) shipped

I think that tests on 20.18.1 (the minimum engine requirement from package.json) are likely to fail on CI, actually.
In main, not just on this PR

20.19.0 should pass though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant