feat(F1/F6): unify watch implementations into FileWatcher - #113
Merged
Conversation
Unify Command::pollChanges and WatchRunner::pollChanges into a single FileWatcher class with inotify backend (Linux), polling fallback, and new-file detection. Removes the old mtime-only polling in WatchRunner and the defunct pollChanges/snapshotMtimes from Command. - New FileWatcher class with detectNewFiles/detectDeletedFiles/ detectModifiedFiles and syncFromFileList - FileChangeType enum (Created, Modified, Deleted) - inotify backend on Linux, polling fallback - FileWatcher unit tests - TTY watch mode uses ConsoleLogger for visibility into backend - --watch help text updated (removed 'poll-based')
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Documentation | 35 minor |
| ErrorProne | 7 medium |
| Security | 7 high |
| CodeStyle | 50 minor |
| Complexity | 1 medium |
🟢 Metrics 67 complexity · 0 duplication
Metric Results Complexity 67 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
detain
pushed a commit
that referenced
this pull request
Jul 1, 2026
Phase 11 complete: - 11.2: FileWatcher unification (PR #113, merged 14c2154) - 11.3: Async/queued serve (PR #114, merged c7072ea) - 11.4: phpdup init wizard (PR #115, merged 722ec5e) - 11.5: Per-pair match explainability (PR #116, merged d764267) - Fix 11.1b status (was pending, actually merged 9b2e2ed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Command::pollChangesandWatchRunner::pollChangesinto a singleFileWatcherclass--watch(without--tui) that was previously brokenAcceptance Criteria
--watchpicks up newly-added files--tuibehavior