Feature/tf2 ros - #46
Open
rikba wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Tested demo.launch and on DJI platform. |
michaelpantic
approved these changes
Apr 1, 2021
michaelpantic
left a comment
michaelpantic
left a comment
Member
There was a problem hiding this comment.
Nice, thanks! makes a lot of sense.
I had a quick look at Jenkins, it seems to be missing the tf2 depency. Problem is, I can't change the build config (jenkins throws an error). So at some point might need to setup this build newly. Or do you wanna have a look?
Contributor
Author
|
Thanks, I will have a look. |
|
Shouldn't Jenkins not simply perform a rosdep install? |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last point assumes we use geotf only to transform static coordinate frames.