Conversation
|
@lgarrison any criticism welcome - this adds a togglable/sortable column in the format style of Separately, ceph also has an |
lgarrison
left a comment
There was a problem hiding this comment.
Looks great! Have you explored the rctime xattr at all? I assume it's like a recursive mtime, which could potentially be more intuitive, since all the other attributes we display are recursive. On the other hand, some old ceph bug reports seem to suggest it's not reliable or at least not updated promptly.
|
I went ahead and swapped mtime out for ctime. We could provide both, but it seems slightly overloaded for now; we can always add it back in. I added a note to It's a bit wider than the scope of this branch, but I also swapped out stat size for xattr size and did a bit of refactoring on the xattr calls. We now do 6 |
|
@lgarrison If we merge this, I'll try and do this before we cut a release:
|
lgarrison
left a comment
There was a problem hiding this comment.
Looks good! I tested it locally and it works great.
Notes / possible changes