This repository was archived by the owner on Jan 31, 2025. It is now read-only.
Cleanup Systemd files and add Travis-CI test for Systemd#12
Open
jamrok wants to merge 2 commits intogeerlingguy:masterfrom
Open
Cleanup Systemd files and add Travis-CI test for Systemd#12jamrok wants to merge 2 commits intogeerlingguy:masterfrom
jamrok wants to merge 2 commits intogeerlingguy:masterfrom
Conversation
Owner
|
Can you clean up the changes based on #10? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observation:
I was testing with Molecule on an Ubuntu 18.04 host and each time I created privileged containers using your Debian based images that support Systemd, it logged me out (Red Hat based images worked without a problem). Creating the containers manually caused the same problem (as expected).
Root Cause:
Extraneous Systemd files + privileged mode = troubling times in the kingdom.
Recommendation:
findto do the same cleanup as listed here.Testing:
The following shows the Systemd status when the files are present (your image before the change):
https://travis-ci.com/jamrok/docker-ubuntu1804-ansible/builds/101129316#L1102-L1135
The following shows the Systemd status when the files are removed (after the change):
https://travis-ci.com/jamrok/docker-ubuntu1804-ansible/jobs/178182250#L1106-L1120
I was checking your Issues and it seems this might solve for #9 as well.
Let me know what you think,
Thanks