Skip to content

feat(falcon): Set name and source on request span when streaming#6562

Merged
alexander-alderman-webb merged 17 commits into
masterfrom
webb/falcon/txn-name
Jun 16, 2026
Merged

feat(falcon): Set name and source on request span when streaming#6562
alexander-alderman-webb merged 17 commits into
masterfrom
webb/falcon/txn-name

docstring v2

2943c3d
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: find-bugs completed Jun 16, 2026 in 0s

1 issue

find-bugs: Found 1 issue (1 low)

Low

Dead `capture_items("event")` assignment immediately overwritten in falcon test - `tests/integrations/falcon/test_falcon.py:126-127`

In test_transaction_style, the span_streaming branch calls items = capture_items("event") and then immediately overwrites items with capture_items("event", "span") on the next line. The first call's return list is never used, and because capture_items monkeypatches test_client.transport.capture_envelope on each invocation, the redundant first call installs an extra nested transport patch whose collected list is discarded. The first line should be removed.


⏱ 3m 50s · 473.5k in / 25.4k out · $0.72